chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc ('k') | chrome/browser/password_manager/password_store_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index 51b60b8226b9eeabc8d32d7fdda137731fe70e72..30044d715ad4ba60effc26efeae821fc20b11235 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -240,8 +240,8 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(

password_manager::metrics_util::GroupIdToString(

password_manager::metrics_util::MonitoredDomainGroupId(

form_to_save->pending_credentials().signon_realm, GetPrefs())));

- SavePasswordInfoBarDelegate::Create(

- web_contents(), form_to_save.Pass(), uma_histogram_suffix, type);

+ SavePasswordInfoBarDelegate::Create(web_contents(), std::move(form_to_save),

+ uma_histogram_suffix, type);

#else

NOTREACHED() << "Aura platforms should always use the bubble";

#endif

@@ -258,8 +258,9 @@ bool ChromePasswordManagerClient::PromptUserToChooseCredentials(

// Deletes itself on the event from Java counterpart, when user interacts with

// dialog.

AccountChooserDialogAndroid* acccount_chooser_dialog =

- new AccountChooserDialogAndroid(web_contents(), local_forms.Pass(),

- federated_forms.Pass(), origin, callback);

+ new AccountChooserDialogAndroid(web_contents(), std::move(local_forms),

+ std::move(federated_forms), origin,

+ callback);

acccount_chooser_dialog->ShowDialog();

return true;

#else