chrome/browser/android/net/external_estimate_provider_android_unittest.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/net/external_estimate_provider_android_unittest.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/dev_tools_server.cc ('K') | « chrome/browser/android/most_visited_sites.cc ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/net/external_estimate_provider_android_unittest.cc

diff --git a/chrome/browser/android/net/external_estimate_provider_android_unittest.cc b/chrome/browser/android/net/external_estimate_provider_android_unittest.cc

index 4c1de55b43fa93e010bf4fcff674ba628fcf54cb..b5205816a3c68d151f8019679fb2a2b1b95f855d 100644

--- a/chrome/browser/android/net/external_estimate_provider_android_unittest.cc

+++ b/chrome/browser/android/net/external_estimate_provider_android_unittest.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/android/net/external_estimate_provider_android.h"

#include <stdint.h>

+#include <utility>

#include "base/at_exit.h"

#include "base/test/histogram_tester.h"

@@ -38,7 +39,7 @@ class TestNetworkQualityEstimator : public net::NetworkQualityEstimator {

scoped_ptr<chrome::android::ExternalEstimateProviderAndroid>

external_estimate_provider,

const std::map<std::string, std::string>& variation_params)

- : NetworkQualityEstimator(external_estimate_provider.Pass(),

+ : NetworkQualityEstimator(std::move(external_estimate_provider),

variation_params),

notified_(false) {}

@@ -81,7 +82,7 @@ TEST(ExternalEstimateProviderAndroidTest, DelegateTest) {

TestExternalEstimateProviderAndroid* ptr = external_estimate_provider.get();

std::map<std::string, std::string> variation_params;

TestNetworkQualityEstimator network_quality_estimator(

- external_estimate_provider.Pass(), variation_params);

+ std::move(external_estimate_provider), variation_params);

ptr->NotifyUpdatedEstimateAvailable();

DCHECK(network_quality_estimator.IsNotified());