chrome/browser/ui/ash/chrome_keyboard_ui.cc - Issue 1550983003: Give the ChromeVox Panel an extension view type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/chrome_keyboard_ui.cc

Issue 1550983003: Give the ChromeVox Panel an extension view type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: VIEW_TYPE_COMPONENT Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/chrome_keyboard_ui.cc

diff --git a/chrome/browser/ui/ash/chrome_keyboard_ui.cc b/chrome/browser/ui/ash/chrome_keyboard_ui.cc

index 18efdcefca1eafc321a2bb2e5a4d89639f9b39d0..71408e68f8cacf876dc124e0b36f81c404faf789 100644

--- a/chrome/browser/ui/ash/chrome_keyboard_ui.cc

+++ b/chrome/browser/ui/ash/chrome_keyboard_ui.cc

@@ -143,7 +143,7 @@ void ChromeKeyboardUI::RequestAudioInput(

}

void ChromeKeyboardUI::SetupWebContents(content::WebContents* contents) {

- extensions::SetViewType(contents, extensions::VIEW_TYPE_VIRTUAL_KEYBOARD);

+ extensions::SetViewType(contents, extensions::VIEW_TYPE_COMPONENT);

extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(

contents);

Observe(contents);