Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: chrome/browser/chromeos/accessibility/chromevox_panel.cc

Issue 1550983003: Give the ChromeVox Panel an extension view type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: VIEW_TYPE_COMPONENT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/webui_login_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/chromevox_panel.cc
diff --git a/chrome/browser/chromeos/accessibility/chromevox_panel.cc b/chrome/browser/chromeos/accessibility/chromevox_panel.cc
index 28a8f90c575d9311efd10542ed14ec97f397f988..3710d53acd27b3725a26ae71dd9844d29a7d98ba 100644
--- a/chrome/browser/chromeos/accessibility/chromevox_panel.cc
+++ b/chrome/browser/chromeos/accessibility/chromevox_panel.cc
@@ -8,8 +8,10 @@
#include "base/macros.h"
#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
#include "chrome/browser/chromeos/accessibility/chromevox_panel.h"
+#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
#include "chrome/common/extensions/extension_constants.h"
#include "content/public/browser/web_contents.h"
+#include "extensions/browser/view_type_utils.h"
#include "ui/chromeos/accessibility_types.h"
#include "ui/views/controls/webview/webview.h"
#include "ui/views/layout/fill_layout.h"
@@ -64,8 +66,12 @@ ChromeVoxPanel::ChromeVoxPanel(content::BrowserContext* browser_context)
url += kChromeVoxPanelRelativeUrl;
views::WebView* web_view = new views::WebView(browser_context);
+ content::WebContents* contents = web_view->GetWebContents();
web_contents_observer_.reset(
- new ChromeVoxPanelWebContentsObserver(web_view->GetWebContents(), this));
+ new ChromeVoxPanelWebContentsObserver(contents, this));
+ extensions::SetViewType(contents, extensions::VIEW_TYPE_COMPONENT);
+ extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
+ contents);
web_view->LoadInitialURL(GURL(url));
web_view_ = web_view;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/webui_login_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698