extensions/browser/process_manager.cc - Issue 1550983003: Give the ChromeVox Panel an extension view type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/process_manager.cc

Issue 1550983003: Give the ChromeVox Panel an extension view type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add VIEW_TYPE_EXTENSION_OTHER Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/process_manager.cc

diff --git a/extensions/browser/process_manager.cc b/extensions/browser/process_manager.cc

index c3eaad55a1763c4157733c7a58c127962f6d598b..6fb12963e1a83868e11285145c886394d92aaa2c 100644

--- a/extensions/browser/process_manager.cc

+++ b/extensions/browser/process_manager.cc

@@ -168,6 +168,7 @@ struct ProcessManager::ExtensionRenderFrameData {

case VIEW_TYPE_BACKGROUND_CONTENTS:

case VIEW_TYPE_EXTENSION_DIALOG:

case VIEW_TYPE_EXTENSION_GUEST:

+ case VIEW_TYPE_EXTENSION_OTHER:

Devlin 2016/01/04 18:29:14 Having a pseudo-dummy tag have keepalive makes me

dmazzoni 2016/01/04 18:42:13 ChromeVox doesn't need this, so moved below.

case VIEW_TYPE_EXTENSION_POPUP:

case VIEW_TYPE_LAUNCHER_PAGE:

case VIEW_TYPE_PANEL: