Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1550983002: Revert of Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ScrollbarThemeAura selectively invalidate scrollbar parts. (patchset #10 id:180001 of https://codereview.chromium.org/1525803002/ ) Reason for revert: Oilpan unit test failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/builds/28217 Original issue's description: > Make ScrollbarThemeAura selectively invalidate scrollbar parts. > > In particular: > - when hovering or pressing the thumb, repaint only the thumb > - when thumb position changes, repaint the track only if it changes > (e.g. due to a button being disabled upon reaching the end) > > BUG=549277 > > Committed: https://crrev.com/0e8396ada46f085c23343450d850d81751053c94 > Cr-Commit-Position: refs/heads/master@{#367082} TBR=ccameron@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549277 Committed: https://crrev.com/55904fbf48eba4730c1de0fe9e38e89942b2c8c7 Cr-Commit-Position: refs/heads/master@{#367096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -270 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 6 chunks +3 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 5 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 5 chunks +25 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 3 chunks +41 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
Created Revert of Make ScrollbarThemeAura selectively invalidate scrollbar parts.
4 years, 11 months ago (2015-12-29 20:00:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550983002/1
4 years, 11 months ago (2015-12-29 20:00:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550983002/1
4 years, 11 months ago (2015-12-29 20:03:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 20:04:31 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 20:05:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55904fbf48eba4730c1de0fe9e38e89942b2c8c7
Cr-Commit-Position: refs/heads/master@{#367096}

Powered by Google App Engine
This is Rietveld 408576698