Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550963002: Remove RefCountedMallocedMemory, it's not used. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RefCountedMallocedMemory, it's not used. Committed: https://crrev.com/fa795f7fdd523c3eb649c5452414b233a861d3ce Cr-Commit-Position: refs/heads/master@{#367114}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M base/memory/ref_counted_memory.h View 1 chunk +0 lines, -20 lines 0 comments Download
M base/memory/ref_counted_memory.cc View 1 2 chunks +0 lines, -20 lines 0 comments Download
M base/memory/ref_counted_memory_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
FTR, someone missed RefCountedBytes and went for RefCountedMallocedMemory instead. I thought that was odd and ...
4 years, 11 months ago (2015-12-29 19:11:21 UTC) #2
brettw
lgtm
4 years, 11 months ago (2015-12-29 22:08:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550963002/20001
4 years, 11 months ago (2015-12-29 22:13:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-29 23:15:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 23:16:19 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fa795f7fdd523c3eb649c5452414b233a861d3ce
Cr-Commit-Position: refs/heads/master@{#367114}

Powered by Google App Engine
This is Rietveld 408576698