Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/common/linux/synth_elf.h

Issue 1550933002: Let breakpad build with -Wall on OS X and Linux. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/common/linux/libcurl_wrapper.h ('k') | src/common/linux/synth_elf.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // -*- mode: C++ -*- 1 // -*- mode: C++ -*-
2 2
3 // Copyright (c) 2011, Google Inc. 3 // Copyright (c) 2011, Google Inc.
4 // All rights reserved. 4 // All rights reserved.
5 // 5 //
6 // Redistribution and use in source and binary forms, with or without 6 // Redistribution and use in source and binary forms, with or without
7 // modification, are permitted provided that the following conditions are 7 // modification, are permitted provided that the following conditions are
8 // met: 8 // met:
9 // 9 //
10 // * Redistributions of source code must retain the above copyright 10 // * Redistributions of source code must retain the above copyright
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 SymbolTable(Endianness endianness, size_t addr_size, StringTable& table); 166 SymbolTable(Endianness endianness, size_t addr_size, StringTable& table);
167 167
168 // Add an Elf32_Sym. 168 // Add an Elf32_Sym.
169 void AddSymbol(const string& name, uint32_t value, 169 void AddSymbol(const string& name, uint32_t value,
170 uint32_t size, unsigned info, uint16_t shndx); 170 uint32_t size, unsigned info, uint16_t shndx);
171 // Add an Elf64_Sym. 171 // Add an Elf64_Sym.
172 void AddSymbol(const string& name, uint64_t value, 172 void AddSymbol(const string& name, uint64_t value,
173 uint64_t size, unsigned info, uint16_t shndx); 173 uint64_t size, unsigned info, uint16_t shndx);
174 174
175 private: 175 private:
176 #ifndef NDEBUG
176 size_t addr_size_; 177 size_t addr_size_;
178 #endif
177 StringTable& table_; 179 StringTable& table_;
178 }; 180 };
179 181
180 // A class for note sections 182 // A class for note sections
181 class Notes : public Section { 183 class Notes : public Section {
182 public: 184 public:
183 Notes(Endianness endianness) 185 Notes(Endianness endianness)
184 : Section(endianness) { 186 : Section(endianness) {
185 } 187 }
186 188
187 // Add a note. 189 // Add a note.
188 void AddNote(int type, const string &name, const uint8_t* desc_bytes, 190 void AddNote(int type, const string &name, const uint8_t* desc_bytes,
189 size_t desc_size); 191 size_t desc_size);
190 }; 192 };
191 193
192 } // namespace synth_elf 194 } // namespace synth_elf
193 } // namespace google_breakpad 195 } // namespace google_breakpad
194 196
195 #endif // COMMON_LINUX_SYNTH_ELF_H_ 197 #endif // COMMON_LINUX_SYNTH_ELF_H_
OLDNEW
« no previous file with comments | « src/common/linux/libcurl_wrapper.h ('k') | src/common/linux/synth_elf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698