Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: src/ic/ppc/handler-compiler-ppc.cc

Issue 1550923002: Remove uses of result size in TailCallRuntime and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: change spaces Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips64/ic-mips64.cc ('k') | src/ic/ppc/ic-compiler-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 VectorStoreICDescriptor::SlotRegister(), 317 VectorStoreICDescriptor::SlotRegister(),
318 VectorStoreICDescriptor::VectorRegister()); 318 VectorStoreICDescriptor::VectorRegister());
319 } 319 }
320 320
321 321
322 void NamedStoreHandlerCompiler::GenerateSlow(MacroAssembler* masm) { 322 void NamedStoreHandlerCompiler::GenerateSlow(MacroAssembler* masm) {
323 StoreIC_PushArgs(masm); 323 StoreIC_PushArgs(masm);
324 324
325 // The slow case calls into the runtime to complete the store without causing 325 // The slow case calls into the runtime to complete the store without causing
326 // an IC miss that would otherwise cause a transition to the generic stub. 326 // an IC miss that would otherwise cause a transition to the generic stub.
327 __ TailCallRuntime(Runtime::kStoreIC_Slow, 5, 1); 327 __ TailCallRuntime(Runtime::kStoreIC_Slow, 5);
328 } 328 }
329 329
330 330
331 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) { 331 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) {
332 StoreIC_PushArgs(masm); 332 StoreIC_PushArgs(masm);
333 333
334 // The slow case calls into the runtime to complete the store without causing 334 // The slow case calls into the runtime to complete the store without causing
335 // an IC miss that would otherwise cause a transition to the generic stub. 335 // an IC miss that would otherwise cause a transition to the generic stub.
336 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow, 5, 1); 336 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow, 5);
337 } 337 }
338 338
339 339
340 #undef __ 340 #undef __
341 #define __ ACCESS_MASM(masm()) 341 #define __ ACCESS_MASM(masm())
342 342
343 343
344 void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label, 344 void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label,
345 Handle<Name> name) { 345 Handle<Name> name) {
346 if (!label->is_unused()) { 346 if (!label->is_unused()) {
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 698
699 699
700 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { 700 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) {
701 // Call the runtime system to load the interceptor. 701 // Call the runtime system to load the interceptor.
702 DCHECK(holder()->HasNamedInterceptor()); 702 DCHECK(holder()->HasNamedInterceptor());
703 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined()); 703 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined());
704 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 704 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
705 holder()); 705 holder());
706 706
707 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor, 707 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor,
708 NamedLoadHandlerCompiler::kInterceptorArgsLength, 1); 708 NamedLoadHandlerCompiler::kInterceptorArgsLength);
709 } 709 }
710 710
711 711
712 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 712 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
713 Handle<JSObject> object, Handle<Name> name, 713 Handle<JSObject> object, Handle<Name> name,
714 Handle<ExecutableAccessorInfo> callback) { 714 Handle<ExecutableAccessorInfo> callback) {
715 Register holder_reg = Frontend(name); 715 Register holder_reg = Frontend(name);
716 716
717 __ Push(receiver(), holder_reg); // receiver 717 __ Push(receiver(), holder_reg); // receiver
718 718
719 // If the callback cannot leak, then push the callback directly, 719 // If the callback cannot leak, then push the callback directly,
720 // otherwise wrap it in a weak cell. 720 // otherwise wrap it in a weak cell.
721 if (callback->data()->IsUndefined() || callback->data()->IsSmi()) { 721 if (callback->data()->IsUndefined() || callback->data()->IsSmi()) {
722 __ mov(ip, Operand(callback)); 722 __ mov(ip, Operand(callback));
723 } else { 723 } else {
724 Handle<WeakCell> cell = isolate()->factory()->NewWeakCell(callback); 724 Handle<WeakCell> cell = isolate()->factory()->NewWeakCell(callback);
725 __ mov(ip, Operand(cell)); 725 __ mov(ip, Operand(cell));
726 } 726 }
727 __ push(ip); 727 __ push(ip);
728 __ mov(ip, Operand(name)); 728 __ mov(ip, Operand(name));
729 __ Push(ip, value()); 729 __ Push(ip, value());
730 730
731 // Do tail-call to the runtime system. 731 // Do tail-call to the runtime system.
732 __ TailCallRuntime(Runtime::kStoreCallbackProperty, 5, 1); 732 __ TailCallRuntime(Runtime::kStoreCallbackProperty, 5);
733 733
734 // Return the generated code. 734 // Return the generated code.
735 return GetCode(kind(), Code::FAST, name); 735 return GetCode(kind(), Code::FAST, name);
736 } 736 }
737 737
738 738
739 Handle<Code> NamedStoreHandlerCompiler::CompileStoreInterceptor( 739 Handle<Code> NamedStoreHandlerCompiler::CompileStoreInterceptor(
740 Handle<Name> name) { 740 Handle<Name> name) {
741 __ Push(receiver(), this->name(), value()); 741 __ Push(receiver(), this->name(), value());
742 742
743 // Do tail-call to the runtime system. 743 // Do tail-call to the runtime system.
744 __ TailCallRuntime(Runtime::kStorePropertyWithInterceptor, 3, 1); 744 __ TailCallRuntime(Runtime::kStorePropertyWithInterceptor, 3);
745 745
746 // Return the generated code. 746 // Return the generated code.
747 return GetCode(kind(), Code::FAST, name); 747 return GetCode(kind(), Code::FAST, name);
748 } 748 }
749 749
750 750
751 Register NamedStoreHandlerCompiler::value() { 751 Register NamedStoreHandlerCompiler::value() {
752 return StoreDescriptor::ValueRegister(); 752 return StoreDescriptor::ValueRegister();
753 } 753 }
754 754
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
786 // Return the generated code. 786 // Return the generated code.
787 return GetCode(kind(), Code::NORMAL, name); 787 return GetCode(kind(), Code::NORMAL, name);
788 } 788 }
789 789
790 790
791 #undef __ 791 #undef __
792 } // namespace internal 792 } // namespace internal
793 } // namespace v8 793 } // namespace v8
794 794
795 #endif // V8_TARGET_ARCH_ARM 795 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/mips64/ic-mips64.cc ('k') | src/ic/ppc/ic-compiler-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698