Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1550893002: Try using std::call_once (Closed)

Created:
4 years, 12 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Try using std::call_once Now that we've got std library support, perhaps we should start using it. This CL acts as a little canary, and may help fix the linked bug. I'm not really sure what's going on in the linked bug, but using std::call_once over homegrown atomics has to be the right answer... BUG=chromium:418041 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1550893002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Going to land this ahead of review while the tree is quiet to see how it rolls. TBR=herb@google.com Committed: https://skia.googlesource.com/skia/+/8895b72f789e5dc8bb99cb9727875439005fc919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M src/opts/opts_check_x86.cpp View 3 chunks +15 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550893002/1
4 years, 12 months ago (2015-12-29 05:59:13 UTC) #3
mtklein_C
4 years, 12 months ago (2015-12-29 06:25:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550893002/1
4 years, 12 months ago (2015-12-29 06:26:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8895b72f789e5dc8bb99cb9727875439005fc919
4 years, 12 months ago (2015-12-29 06:27:21 UTC) #11
herb_g
lgtm
4 years, 11 months ago (2015-12-29 17:47:02 UTC) #12
herb_g
lgtm
4 years, 11 months ago (2015-12-29 17:47:05 UTC) #13
mtklein
4 years, 11 months ago (2016-01-05 02:18:40 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1552333003/ by mtklein@google.com.

The reason for reverting is: Can't use on XP.  :(.

Powered by Google App Engine
This is Rietveld 408576698