Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550863002: impl/memory: Add "PULL" as valid taskqueue method. (Closed)

Created:
4 years, 11 months ago by dnj
Modified:
4 years, 11 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

impl/memory: Add "PULL" as valid taskqueue method. BUG= Committed: https://github.com/luci/gae/commit/e6cee59164d15efb62174273e86403e1a9b5faae

Patch Set 1 #

Patch Set 2 : Pull tasks can have data. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M impl/memory/taskqueue_data.go View 1 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dnj
PTAL, See Task.Method: https://cloud.google.com/appengine/docs/go/taskqueue/reference#Task
4 years, 11 months ago (2015-12-29 01:49:40 UTC) #2
Vadim Sh.
lgtm
4 years, 11 months ago (2015-12-29 01:57:00 UTC) #3
dnj
FYI, updated a bit. Going to hold off committing until my local tests run to ...
4 years, 11 months ago (2015-12-29 02:58:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550863002/20001
4 years, 11 months ago (2015-12-29 23:08:00 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 23:10:41 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/e6cee59164d15efb62174273e86403e1a9b5faae

Powered by Google App Engine
This is Rietveld 408576698