Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1550853002: Make the OCSP Init Singleton Lazy (Closed)

Created:
4 years, 12 months ago by Ryan Sleevi
Modified:
4 years, 12 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the OCSP Init Singleton Lazy As the OCSP Init code (for NSS) is a non-leaky Singleton, but the other NSS code is, we end up calling into it during shutdown while other requests may still be pending. Since the code is, unfortunately, not exactly the most thread safe, the right answer is to just not attempt to cleanup on shutdown, same as all the other NSS code. BUG=572727 Committed: https://crrev.com/10682844c172adadd6227deb5bf06de07c4fc6fa Cr-Commit-Position: refs/heads/master@{#367024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M net/cert_net/nss_ocsp.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ryan Sleevi
eroman: Stamp?
4 years, 12 months ago (2015-12-28 22:12:40 UTC) #2
eroman
lgtm
4 years, 12 months ago (2015-12-28 22:18:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550853002/1
4 years, 12 months ago (2015-12-28 22:27:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 23:49:25 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 23:50:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10682844c172adadd6227deb5bf06de07c4fc6fa
Cr-Commit-Position: refs/heads/master@{#367024}

Powered by Google App Engine
This is Rietveld 408576698