Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: net/BUILD.gn

Issue 1550843002: Convert enable_bidirectional_stream into build flag local to net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 4ca6128f1888119f336ed9d40fcce6e5236103d3..be1ab3e48142cdd666f704493ef5de60a3fc8178 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/buildflag_header.gni")
import("//build/config/chromecast_build.gni")
import("//build/config/compiler/compiler.gni")
import("//build/config/crypto.gni")
@@ -43,6 +44,8 @@ enable_built_in_dns = !is_ios
declare_args() {
# Disables support for file URLs. File URL support requires use of icu.
disable_file_support = false
+
+ # Enables BidirectionalStream; Used in cronet, disabled by default.
enable_bidirectional_stream = false
# WebSockets and socket stream code are not used on iOS and are optional in
@@ -62,9 +65,6 @@ config("net_config") {
if (disable_ftp_support) {
defines += [ "DISABLE_FTP_SUPPORT=1" ]
}
- if (enable_bidirectional_stream) {
- defines += [ "ENABLE_BIDIRECTIONAL_STREAM=1" ]
- }
}
# net_internal_config is shared with net and net_small.
@@ -105,6 +105,7 @@ net_shared_configs = [
]
net_shared_public_deps = [
+ ":features",
":net_quic_proto",
"//crypto",
"//crypto:platform",
@@ -1717,3 +1718,9 @@ executable("net_perftests") {
sources -= [ "proxy/proxy_resolver_perftest.cc" ]
}
}
+
+buildflag_header("features") {
+ header = "net_features.h"
+
+ flags = [ "ENABLE_BIDIRECTIONAL_STREAM=$enable_bidirectional_stream" ]
+}

Powered by Google App Engine
This is Rietveld 408576698