Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1550803006: Convert runtime atomics functions to inline asm (Closed)

Created:
4 years, 11 months ago by binji
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert runtime atomics functions to inline asm This is the first step to optimizing Atomics accesses in TF. The instruction sequences must be identical for all compilers. Since runtime functions are shared by all compilers by default, it's a convenient way to share the instruction sequences as well. This CL only implements the inline assembly for ia32 and x64 on gcc/clang and for ia32 on MSVC. MSVC does not support inline assembly for x64, so in that case we use a separate assembly source file. For all other architectures, we use the gcc/clang intrinsics for now. BUG=v8:4614

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : msvc #

Patch Set 4 : fix presubmit warnings #

Patch Set 5 : year + include guard #

Patch Set 6 : fix StoreSeqCst mangling on msvc, and 8-bit register constraints on ia32 #

Patch Set 7 : update BUILD.gn, add *-inl.h and *.h to gyp as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2023 lines, -161 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 4 chunks +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 1 2 3 13 chunks +45 lines, -155 lines 0 comments Download
A + src/runtime/runtime-atomics-ia32-inl.h View 1 2 3 4 1 chunk +2 lines, -6 lines 0 comments Download
A src/runtime/runtime-atomics-intrinsics-inl.h View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A src/runtime/runtime-atomics-x64.h View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
A src/runtime/runtime-atomics-x64.asm View 1 2 3 4 5 1 chunk +424 lines, -0 lines 0 comments Download
A src/runtime/runtime-atomics-x64-inl.h View 1 2 3 4 5 1 chunk +1391 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 6 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
binji
PTAL
4 years, 11 months ago (2016-01-09 02:53:05 UTC) #4
binji
4 years, 11 months ago (2016-01-12 21:14:15 UTC) #5
On 2016/01/09 02:53:05, binji wrote:
> PTAL

ping

Powered by Google App Engine
This is Rietveld 408576698