Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550803002: Fix log spam when time_in_state file is not available under cpu2/cpu3 (Closed)

Created:
4 years, 12 months ago by Yoland Yan(Google)
Modified:
4 years, 12 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix log spam when time_in_state file is not available under cpu2/cpu3 BUG=561190 Committed: https://crrev.com/ad8cdf36a37c5c52edef2f8b25b09a2350adaf12 Cr-Commit-Position: refs/heads/master@{#367042}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Grammar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yoland Yan(Google)
4 years, 12 months ago (2015-12-28 19:38:32 UTC) #2
mikecase (-- gone --)
non-owner lgtm https://codereview.chromium.org/1550803002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/1550803002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py#newcode123 tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py:123: 'Cannot read cpu frequency times for %s ...
4 years, 12 months ago (2015-12-28 19:58:07 UTC) #3
Yoland Yan(Google)
https://codereview.chromium.org/1550803002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/1550803002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py#newcode123 tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py:123: 'Cannot read cpu frequency times for %s due to ...
4 years, 12 months ago (2015-12-28 23:04:10 UTC) #4
nednguyen
lgtm
4 years, 12 months ago (2015-12-29 01:34:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550803002/20001
4 years, 12 months ago (2015-12-29 01:45:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-29 02:57:38 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ad8cdf36a37c5c52edef2f8b25b09a2350adaf12 Cr-Commit-Position: refs/heads/master@{#367042}
4 years, 12 months ago (2015-12-29 02:58:42 UTC) #11
Yoland Yan(Google)
4 years, 11 months ago (2015-12-29 18:21:23 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1550303002/ by yolandyan@google.com.

The reason for reverting is: Broke android perf bots.

Powered by Google App Engine
This is Rietveld 408576698