Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15508003: Revert "Don't force layout for mouse event hit tests" (Closed)

Created:
7 years, 7 months ago by cbiesinger
Modified:
7 years, 7 months ago
Reviewers:
ojan
CC:
blink-reviews, kinuko, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert "Don't force layout for mouse event hit tests" This reverts commit c7cb8114b1071115521af0286a2dbfedb22b5e5f. also reverts 02e89444b7cb08bc9fae08956ae361ec4d03ac19 Reverting because I somehow missed some tests BUG=1373 TBR=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -285 lines) Patch
M LayoutTests/editing/pasteboard/data-transfer-items.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/editing/selection/contenteditable-click-inside.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/editing/selection/script-tests/click-outside-editable-div.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/block/float/float-in-float-hit-testing.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-generated-content/hover-style-change.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/hover-active-drag.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/layerZOrderCrash.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/resize-corner-tracking-transformed.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/resize-corner-tracking-transformed-iframe.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-width.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-xy-properties.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/replaced-image-map.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/capture-on-target.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/clientXY-in-zoom-and-scroll.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/dblclick-addEventListener.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/drop-with-file-paths.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/event-view-toString.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/frame-click-focus.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/mouse-focus-imagemap.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/mouseclick-target-and-positioning.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/mouseout-on-window.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/mouseup-outside-document.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/pointer-events.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/pointer-events-2.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/prevent-drag-to-navigate.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/related-target.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/script-tests/mouse-click-events.js View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/events/script-tests/page-scaled-mouse-click.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/script-tests/page-scaled-mouse-click-iframe.js View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/scrollbar-double-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/emulate-touch-events.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-dblclick.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-tap-active-state.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/updateLayoutForHitTest.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/window-events-bubble.html View 2 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/fast/events/window-events-bubble2.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/window-events-capture.html View 2 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/fast/events/zoom-dblclick.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/apply-blob-url-to-xhr.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/file-list-test.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/file-reader-abort.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/file-reader-event-listener.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/resources/setup-for-read-common.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/workers/worker-apply-blob-url-to-xhr.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/file/get-file-upload.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/file/input-file-re-render.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/input-appearance-preventDefault.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-text-click-inside.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-text-click-outside.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-text-double-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-text-drag-down.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-text-self-emptying-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/option-mouseevents.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/password-doubleclick-selection.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/select-empty-list.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frame-deep-nested-resize.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-1-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-10-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-2-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-3-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-4-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-5-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-6-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-7-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-8-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-9-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-mouse-click.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-1-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-2-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-3-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-4-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-5-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-6-and-click.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/images/image-map-multiple.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/images/image-map-multiple-xhtml.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/images/image-map-zoom.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/images/imagemap-case.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/images/script-tests/imagemap-dynamic-area-updates.js View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/repaint/event-while-loading.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/repaint/event-while-loading-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/japanese-rl-selection-clear.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/replaced/image-map.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/replaced/image-map-bug16782.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/scrolling/hover-during-scroll.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/text/atsui-rtl-override-selection.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/text/international/khmer-selection.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/text/textIteratorNilRenderer.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/local/blob/script-tests/send-hybrid-blob.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/javascriptlink.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/plugins/user-gesture.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/scrollbars/scrollbar-miss-mousemove-disabled.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/svg/custom/anchor-on-use.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/gradient-attr-update.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/hit-test-path.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/hit-test-path-stroke.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/hover-default-fill.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/image-clipped-hit.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-all.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-preserveAspectRatio.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-transform.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-viewBox.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-viewBox-transform.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-viewTarget.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-zoomAndPan.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/linking-uri-01-b.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/marker-changes.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/mask-changes.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-container.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-container-standalone.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-root.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-root-standalone.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pan-direction.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-image.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-image-css-transform.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-on-rounded-rect.xhtml View 2 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/svg/custom/pointer-events-on-svg-with-pointer.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/pointer-events-on-svg-without-pointer.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/pointer-events-path.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-text.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-text-css-transform.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/polyline-hittest.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/resources/focus-event-handling.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/stroke-width-click.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/text-hit-test.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/use-css-events.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/use-move-to-offset.svg View Binary file 0 comments Download
M LayoutTests/svg/custom/viewBox-hit.svg View Binary file 0 comments Download
M LayoutTests/touchadjustment/block-testing.html View 2 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/touchadjustment/context-menu.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/context-menu-select-text.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/context-menu-text-subtargets.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/disabled-formelements.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/rotated-node.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/touch-inlines.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/zoom-basic.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/touchadjustment/zoom-fatfinger.html View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
cbiesinger
7 years, 7 months ago (2013-05-20 23:24:07 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r150716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698