Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1550793002: Make blimp_engine_bundle action silent when successful. (Closed)

Created:
4 years, 11 months ago by maniscalco
Modified:
4 years, 11 months ago
Reviewers:
Kevin M, Wez
CC:
chromium-reviews, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make blimp_engine_bundle action silent when successful. Don't write to stdout. Only write to stderr when there's an error. BUG=572396 Committed: https://crrev.com/4920916f6c912cb3f438c8a6f4a568ecf91aaa9e Cr-Commit-Position: refs/heads/master@{#366991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M blimp/tools/bundle-engine.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
maniscalco
4 years, 11 months ago (2015-12-28 17:57:12 UTC) #2
Kevin M
lgtm Wez is OOO, but this looks fine to me.
4 years, 11 months ago (2015-12-28 18:07:12 UTC) #4
maniscalco
On 2015/12/28 18:07:12, Kevin M wrote: > lgtm > > Wez is OOO, but this ...
4 years, 11 months ago (2015-12-28 18:24:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550793002/1
4 years, 11 months ago (2015-12-28 18:24:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-28 18:28:40 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-28 18:29:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4920916f6c912cb3f438c8a6f4a568ecf91aaa9e
Cr-Commit-Position: refs/heads/master@{#366991}

Powered by Google App Engine
This is Rietveld 408576698