third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 1550723003: Adapt MixedContentChecker for remote frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 1550723003: Adapt MixedContentChecker for remote frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alexmos comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 2a86da71d221ddebc047a2fb71340e0eb8a77c9a..00b43dee4db374959ba07d39e99d523a57a5589b 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -203,8 +203,6 @@ void DOMWindow::postMessage(PassRefPtr<SerializedScriptValue> message, const Mes

String sourceOrigin = sourceDocument->securityOrigin()->toString();

String sourceSuborigin = sourceDocument->securityOrigin()->suboriginName();

- // FIXME: MixedContentChecker needs to be refactored for OOPIF. For now,

- // create the url using replicated origins for remote frames.

KURL targetUrl = isLocalDOMWindow() ? document()->url() : KURL(KURL(), frame()->securityContext()->securityOrigin()->toString());

if (MixedContentChecker::isMixedContent(sourceDocument->securityOrigin(), targetUrl))

UseCounter::count(frame(), UseCounter::PostMessageFromSecureToInsecure);