content/test/data/mixed-content/basic-passive-in-iframe.html - Issue 1550723003: Adapt MixedContentChecker for remote frames

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/mixed-content/basic-passive-in-iframe.html

Issue 1550723003: Adapt MixedContentChecker for remote frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alexmos comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 </head>

	5

	6 <body>

	7 </body>

	8 <script>

	9 var url = "/cross-site/a.com/mixed-content/basic-passive.html";

	10 var iframe = document.createElement("iframe");

	11 iframe.src = url;

	12 document.body.appendChild(iframe);
	alexmos 2016/01/20 22:43:55 Is it still necessary to add the iframe via script Is it still necessary to add the iframe via script? Why not just <iframe src="/cross-site/a.com/mixed-content/basic-passive.html"> ? estark 2016/01/21 04:40:13 Oops, leftover from when I was using document.loca Show quoted text On 2016/01/20 22:43:55, alexmos wrote: > Is it still necessary to add the iframe via script? Why not just <iframe > src="/cross-site/a.com/mixed-content/basic-passive.html"> ? Oops, leftover from when I was using document.location.port. Done.
	13 </script>

	14 </html>

OLD	NEW