Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1550713002: Guard the property RegExp.prototype.unicode behind --harmony-regexp-unicode (Closed)

Created:
4 years, 12 months ago by Dan Ehrenberg
Modified:
4 years, 12 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Guard the property RegExp.prototype.unicode behind --harmony-regexp-unicode When the 'y' flag was shipped, the property RegExp.prototype.unicode was accidentally also shipped. However, the existence of this property should be a usable feature testing point. This patch adds the 'unicode' getter on RegExp.prototype only if the --harmony-regexp-unicode flag is turned on. R=cbruni CC=yangguo BUG=v8:4644 LOG=Y Committed: https://crrev.com/9c304f1e78194d1530544721f8eed93011ff9ab9 Cr-Commit-Position: refs/heads/master@{#33049}

Patch Set 1 #

Patch Set 2 : fix newline #

Patch Set 3 : Test262 expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -13 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/js/harmony-regexp.js View 1 chunk +0 lines, -12 lines 0 comments Download
A src/js/harmony-unicode-regexps.js View 1 1 chunk +36 lines, -0 lines 0 comments Download
A test/mjsunit/es6/no-unicode-regexp-flag.js View 1 chunk +24 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550713002/1
4 years, 12 months ago (2015-12-28 01:58:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9296)
4 years, 12 months ago (2015-12-28 02:01:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550713002/20001
4 years, 12 months ago (2015-12-28 03:36:19 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/10386)
4 years, 12 months ago (2015-12-28 03:51:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550713002/40001
4 years, 12 months ago (2015-12-28 04:02:39 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 04:21:42 UTC) #12
Dan Ehrenberg
4 years, 12 months ago (2015-12-28 04:25:55 UTC) #13
Camillo Bruni
lgtm
4 years, 12 months ago (2015-12-28 12:30:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550713002/40001
4 years, 12 months ago (2015-12-28 16:37:22 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 12 months ago (2015-12-28 16:38:44 UTC) #17
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 16:39:01 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9c304f1e78194d1530544721f8eed93011ff9ab9
Cr-Commit-Position: refs/heads/master@{#33049}

Powered by Google App Engine
This is Rietveld 408576698