Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 1550703002: Revert of Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines. (Closed)

Created:
4 years, 12 months ago by wkorman
Modified:
4 years, 12 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines. (patchset #2 id:20001 of https://codereview.chromium.org/1412533002/ ) Reason for revert: Interim fix for http://crbug.com/569175 until we can update script to not strip Pass/Failure lines for tests also matching NeedsRebaseline. Original issue's description: > Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines. > > As per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OI_gXMX7yUs. > > Committed: https://crrev.com/30fe1b01a50cefa35a0578311944e3b09cb27f38 > Cr-Commit-Position: refs/heads/master@{#357741} TBR=dpranke@chromium.org,ojan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569175 Committed: https://crrev.com/15e6ff0a3524008ca07189146a7034519a947378 Cr-Commit-Position: refs/heads/master@{#366947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -74 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 2 chunks +36 lines, -25 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 2 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
wkorman
Created Revert of Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines.
4 years, 12 months ago (2015-12-28 00:41:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550703002/1
4 years, 12 months ago (2015-12-28 00:43:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 00:43:39 UTC) #5
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 00:44:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15e6ff0a3524008ca07189146a7034519a947378
Cr-Commit-Position: refs/heads/master@{#366947}

Powered by Google App Engine
This is Rietveld 408576698