Switch to standard integer types in third_party/crashpad/.

Switch to standard integer types in third_party/crashpad/.

BUG=138542
TBR=mark@chromium.org

Committed: https://crrev.com/562827afb59912adccf5702e9c856c95456dbb8a
Cr-Commit-Position: refs/heads/master@{#366948}

[Avi (use Gerrit), 2015-12-28 00:09:39]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-12-28 00:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1550683003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1550683003/1

[Mark Mentovai, 2015-12-28 00:26:18]

https://codereview.chromium.org/1550683003/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/client/crashpad_info.cc (right):

https://codereview.chromium.org/1550683003/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/client/crashpad_info.cc:17: #include
"build/build_config.h"
The .h already includes this. Is this not something you checked for?

[Avi (use Gerrit), 2015-12-28 00:37:13]

https://codereview.chromium.org/1550683003/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/client/crashpad_info.cc (right):

https://codereview.chromium.org/1550683003/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/client/crashpad_info.cc:17: #include
"build/build_config.h"
On 2015/12/28 00:26:18, Mark Mentovai wrote:
> The .h already includes this. Is this not something you checked for?

This is a practicality thing for me.

The tool does check the header file for things like <stdint.h>, because there's
no ordering issue. No one will be using uint8_t above the #include, so it
doesn't matter.

build/build_config.h is deadly, though. So so so so so many people use OS_*
without including that file, and it's super-easy to also use the OS_* macros
within the #include blocks, even before the line that includes build_config.h.

Therefore, in *any* file that uses the OS_* macros the tool includes
build_config.h. Then, when I review the includes, and I see build_config.h, I
stop to make sure that it precedes the use of OS_*.

If it were indirected through the header file, I wouldn't be able to guarantee
things. So I'm paying the price of overincluding that file to make damn sure
that the OS_* macros are defined when they're used, because the penalty of
getting it wrong is a silent miscompile. (Which, BTW, has happened at least
once; see https://codereview.chromium.org/1544083002/ .)

[commit-bot: I haz the power, 2015-12-28 00:52:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-28 00:53:35]

Description was changed from

==========
Switch to standard integer types in third_party/crashpad/.

BUG=138542
TBR=mark@chromium.org
==========

to

==========
Switch to standard integer types in third_party/crashpad/.

BUG=138542
TBR=mark@chromium.org

Committed: https://crrev.com/562827afb59912adccf5702e9c856c95456dbb8a
Cr-Commit-Position: refs/heads/master@{#366948}
==========

[commit-bot: I haz the power, 2015-12-28 00:53:36]

Patchset 1 (id:??) landed as
https://crrev.com/562827afb59912adccf5702e9c856c95456dbb8a
Cr-Commit-Position: refs/heads/master@{#366948}