Hookup Print HTML page to the DOM UI for Print Preview and Settings...

Hookup Print HTML page to the DOM UI for Print Preview and Settings

Depends on initial foundation: 
http://src.chromium.org/viewvc/chrome?view=rev&revision=19906

And html mockup: 
http://src.chromium.org/viewvc/chrome?view=rev&revision=19918

BUG=173, 947
TEST=The user will see the print html page as a html test webpage.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20595

[Mohamed Mansour, 2009-07-07 23:51:49]

This is the implementation of DOMUI.

Still, I can't figure out how to connect all this together ... Any assistance?

[Mohamed Mansour, 2009-07-08 03:52:33]

We can't use this approach creating a DOMUI since we are using a print: scheme
not a chrome: scheme.  So there is a way to do this if we implement a print:
scheme that uses the DataSource infrastructure for chrome: That way we could
simplify coding. 

Unless there is a better way ;x Please let me know.

[Mohamed Mansour, 2009-07-08 03:53:51]

^^ I meant reimplementing this dude:
chrome/browser/dom_ui/chrome_url_data_manager.h

to be something like:
chrome/browser/dom_ui/print_url_data_manager.h

Its going to be heavy work ;x

[M-A Ruel, 2009-07-08 14:39:36]

I'm definitely not the best reviewer for this part. Could you find someone from
the blame list?

[Mohamed Mansour, 2009-07-09 03:03:32]

Here is the screenshot:
http://i29.tinypic.com/2hzihol.jpg

[Mohamed Mansour, 2009-07-09 03:03:44]

It is all connected.

[M-A Ruel, 2009-07-09 19:21:27]

http://codereview.chromium.org/155067/diff/1012/15
File chrome/browser/child_process_security_policy.cc (right):

http://codereview.chromium.org/155067/diff/1012/15#newcode234
Line 234: 
I'm not fine with adding a partially implemented thing in the official build.
Can you add
#if !defined(GOOGLE_CHROME_BUILD)
at the corresponding place where you enable print: ?

http://codereview.chromium.org/155067/diff/1012/9
File chrome/browser/resources/print_tab.html (right):

http://codereview.chromium.org/155067/diff/1012/9#newcode15
Line 15: <p>Borat says "Very nice!"</p>
Shouldn't you use &quot; ?

[Mohamed Mansour, 2009-07-10 01:53:54]

Done, correct, the best place to put the ifdef would be in the dom_ui_factory
since that is where all the requests go to the DOM page. I tested it, and it
shows an error page when accessing it. So thats cool perhaps.

Yes we should use quotes.

Glen: is everything good at your end for lgtm?

[Mohamed Mansour, 2009-07-13 16:41:47]

Glen: Is everything good? I would like to commit this so I could continue and
work on printing.

[Glen Murphy, 2009-07-14 01:42:42]

LGTM with one comment:

http://codereview.chromium.org/155067/diff/1030/31
File chrome/browser/dom_ui/chrome_url_data_manager.cc (right):

http://codereview.chromium.org/155067/diff/1030/31#newcode144
Line 144: DCHECK(url.SchemeIs(kChromeURLScheme) ||
url.SchemeIs(chrome::kPrintScheme));
Not sure this should be in the else - this scheme should work for
PERSONALIZATION users, too.