Issue 155064: Merge r18936....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155064: Merge r18936.... (Closed)

Created:
11 years, 5 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/

Visibility:
Public.

Description

Merge r18936. "" ==> "Tent_sdch, Tent_gzip" "gzip" ==> "Tent_sdch, Test_gzip, gzip" Note that the TENTATIVE_gzip is a sniffing gzip, that can turn into an identity (no-op) filter if it can't find a gzip header. By continuing to use a tentative SDCH, it is possible for the SDCH filter to make error recovery decision, and to record stats on this case. In addition, I've changed the error recovery approach in the SDCH filter to be ultra conservative. If there is ANY unrecoverable error in a response to an SDCH request, then we will blacklist the host of the URL. Recoverable errors are where the SDCH is fully functional, and decodes its data using the dictionary. The test cases added focus on the double gzip cases, as observed in Vodaphone (UK) Mobile Broadband. BUG=13606 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19925

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+267 lines, -80 lines)			Patch
M	net/base/filter.cc	View	4 chunks	+45 lines, -19 lines	0 comments	Download
M	net/base/gzip_filter_unittest.cc	View	1 chunk	+0 lines, -29 lines	0 comments	Download
MM	net/base/sdch_filter.cc	View	1 chunk	+21 lines, -16 lines	0 comments	Download
MM	net/base/sdch_filter_unittest.cc	View	6 chunks	+199 lines, -14 lines	0 comments	Download
MM	net/base/sdch_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	net/base/sdch_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages