This patch changes the behavior of clear search button in cookies_view to wor...

This patch changes the behavior of clear search button in cookies_view to work as in firefox.
When the dialog is launched the clear search button in the old cookie_view the state of this button is enabled,
but the text field is empty, so the correct behavior is  make the button disabled. Only when the user start typing
in the text field, the clear button will be enabled.

BUG=None
TEST=None

[tfarina (gmail-do not use), 2009-07-06 14:49:10]

Hi Glen,

Can you review this to me?

[Glen Murphy, 2009-07-07 23:39:05]

LG, one nit/question.

http://codereview.chromium.org/155060/diff/1004/3
File chrome/browser/views/options/cookies_view.cc (right):

http://codereview.chromium.org/155060/diff/1004/3#newcode53
Line 53: // TableModel methods.
Why this change? The previous seemed correct.

Alternatively, we use "// Overridden from TableModel" elsewhere.

[tfarina (gmail-do not use), 2009-07-07 23:55:55]

These changes I made was to make these comments equals to others
comments I saw in the code.
browser\bookmarks\bookmark_table_model.h
Line 36
browser\views\options\exceptions_page_view.h
Line 21
browser\views\options\general_page_view.cc
Line 191

These are a couple examples.

On Tue, Jul 7, 2009 at 8:39 PM, <glen@chromium.org> wrote:
> LG, one nit/question.
>
>
> http://codereview.chromium.org/155060/diff/1004/3
> File chrome/browser/views/options/cookies_view.cc (right):
>
> http://codereview.chromium.org/155060/diff/1004/3#newcode53
> Line 53: // TableModel methods.
> Why this change? The previous seemed correct.
>
> Alternatively, we use "// Overridden from TableModel" elsewhere.
>
> http://codereview.chromium.org/155060
>

[tfarina (gmail-do not use), 2009-07-08 17:27:44]

On 2009/07/07 23:55:55, tfarina wrote:
> These changes I made was to make these comments equals to others
> comments I saw in the code.
> browser\bookmarks\bookmark_table_model.h
> Line 36
> browser\views\options\exceptions_page_view.h
> Line 21
> browser\views\options\general_page_view.cc
> Line 191
> 
> These are a couple examples.
> 
> On Tue, Jul 7, 2009 at 8:39 PM, <glen@chromium.org> wrote:
> > LG, one nit/question.
> >
> >
> > http://codereview.chromium.org/155060/diff/1004/3
> > File chrome/browser/views/options/cookies_view.cc (right):
> >
> > http://codereview.chromium.org/155060/diff/1004/3#newcode53
> > Line 53: // TableModel methods.
> > Why this change? The previous seemed correct.
> >
> > Alternatively, we use "// Overridden from TableModel" elsewhere.
> >
> > http://codereview.chromium.org/155060
> >

Glen I added another statement in ResetSearchQuery() to make sure that when the
user clicks in clear_search_button, it will be disabled, that in my opinion is
the right behavior.

[Glen Murphy, 2009-07-08 17:35:53]

LG, with:

http://codereview.chromium.org/155060/diff/6/1007
File chrome/browser/views/options/cookies_view.cc (right):

http://codereview.chromium.org/155060/diff/6/1007#newcode786
Line 786: clear_search_button_->SetEnabled(false);
super minor nit: can you swap the order of these two lines so the field is
cleared and then the button is disabled? (I know it makes no practical
difference)

[tfarina (gmail-do not use), 2009-07-08 17:41:01]

http://codereview.chromium.org/155060/diff/6/1007
File chrome/browser/views/options/cookies_view.cc (right):

http://codereview.chromium.org/155060/diff/6/1007#newcode786
Line 786: clear_search_button_->SetEnabled(false);
On 2009/07/08 17:35:53, Glen Murphy wrote:
> super minor nit: can you swap the order of these two lines so the field is
> cleared and then the button is disabled? (I know it makes no practical
> difference)

Done.