chrome/browser/local_discovery/service_discovery_client_mac.mm - Issue 1550593002: Switch to standard integer types in chrome/browser/, part 2 of 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_mac.mm

Issue 1550593002: Switch to standard integer types in chrome/browser/, part 2 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_client_mac.h ('k') | chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_mac.mm

diff --git a/chrome/browser/local_discovery/service_discovery_client_mac.mm b/chrome/browser/local_discovery/service_discovery_client_mac.mm

index 1c7cd4a22c5699e2fed5836bb07ca59ea9c7e0cc..ada73a808cceaa0db73be8340d7ad04e6018c831 100644

--- a/chrome/browser/local_discovery/service_discovery_client_mac.mm

+++ b/chrome/browser/local_discovery/service_discovery_client_mac.mm

@@ -7,6 +7,8 @@

#import <arpa/inet.h>

#import <Foundation/Foundation.h>

#import <net/if_dl.h>

+#include <stddef.h>

+#include <stdint.h>

#include "base/debug/dump_without_crashing.h"

#include "base/memory/singleton.h"

@@ -100,7 +102,7 @@ void ParseTxtRecord(NSData* record, std::vector<std::string>* output) {

const char* const record_end = record_bytes + [record length];

// TODO(justinlin): More strict bounds checking.

while (record_bytes < record_end) {

- uint8 size = *record_bytes++;

+ uint8_t size = *record_bytes++;

if (size <= 0)

continue;