chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc - Issue 1550593002: Switch to standard integer types in chrome/browser/, part 2 of 4.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc

Issue 1550593002: Switch to standard integer types in chrome/browser/, part 2 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/first_run/try_chrome_dialog_view.cc ('k') | chrome/browser/first_run/upgrade_util_win.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

	6 #include "build/build_config.h"

6 #include "chrome/common/chrome_result_codes.h"	7 #include "chrome/common/chrome_result_codes.h"

7 #include "chrome/common/chrome_switches.h"	8 #include "chrome/common/chrome_switches.h"

8 #include "chrome/test/base/in_process_browser_test.h"	9 #include "chrome/test/base/in_process_browser_test.h"

9	10

10 // Unfortunately, this needs to be Windows only for now. Even though this test	11 // Unfortunately, this needs to be Windows only for now. Even though this test

11 // is meant to exercise code that is for Windows only, it is a good general	12 // is meant to exercise code that is for Windows only, it is a good general

12 // canary in the coal mine for problems related to early shutdown (aborted	13 // canary in the coal mine for problems related to early shutdown (aborted

13 // startup). Sadly, it times out on platforms other than Windows, so I can't	14 // startup). Sadly, it times out on platforms other than Windows, so I can't

14 // enable it for those platforms at the moment. I hope one day our test harness	15 // enable it for those platforms at the moment. I hope one day our test harness

15 // will be improved to support this so we can get coverage on other platforms.	16 // will be improved to support this so we can get coverage on other platforms.

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 // should be enough to trigger the failure. If it is a crash (most likely) then	49 // should be enough to trigger the failure. If it is a crash (most likely) then

49 // look at the callstack and see if any of the components have been touched	50 // look at the callstack and see if any of the components have been touched

50 // recently. Look at recent changes to startup, such as any change to	51 // recently. Look at recent changes to startup, such as any change to

51 // ChromeBrowserMainParts, specifically PreCreateThreadsImpl and see if someone	52 // ChromeBrowserMainParts, specifically PreCreateThreadsImpl and see if someone

52 // has been reordering code blocks for startup. Try reverting any suspicious	53 // has been reordering code blocks for startup. Try reverting any suspicious

53 // changes to see if it affects the test. History shows that waiting until later	54 // changes to see if it affects the test. History shows that waiting until later

54 // only makes the problem worse.	55 // only makes the problem worse.

55 IN_PROC_BROWSER_TEST_F(TryChromeDialogBrowserTest, ToastCrasher) {}	56 IN_PROC_BROWSER_TEST_F(TryChromeDialogBrowserTest, ToastCrasher) {}

56	57

57 #endif // defined(OS_WIN)	58 #endif // defined(OS_WIN)

OLD	NEW