Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4889)

Unified Diff: chrome/browser/views/options/exceptions_page_view.cc

Issue 155059: A patch to make the grid column (table_view) of the passwords_page_vie... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/options/exceptions_page_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/exceptions_page_view.cc
===================================================================
--- chrome/browser/views/options/exceptions_page_view.cc (revision 19491)
+++ chrome/browser/views/options/exceptions_page_view.cc (working copy)
@@ -78,6 +78,10 @@
// ExceptionsPageView, public
ExceptionsPageView::ExceptionsPageView(Profile* profile)
: OptionsPageView(profile),
+ ALLOW_THIS_IN_INITIALIZER_LIST(show_button_(
+ this,
+ l10n_util::GetString(IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON),
+ l10n_util::GetString(IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON))),
ALLOW_THIS_IN_INITIALIZER_LIST(remove_button_(
this,
l10n_util::GetString(IDS_EXCEPTIONS_PAGE_VIEW_REMOVE_BUTTON))),
@@ -125,12 +129,13 @@
SetupTable();
// Do the layout thing.
- const int column_set_id = 0;
GridLayout* layout = CreatePanelGridLayout(this);
SetLayoutManager(layout);
+ const int top_column_set_id = 0;
+
// Design the grid.
- ColumnSet* column_set = layout->AddColumnSet(column_set_id);
+ ColumnSet* column_set = layout->AddColumnSet(top_column_set_id);
column_set->AddColumn(GridLayout::FILL, GridLayout::FILL, 1,
GridLayout::USE_PREF, 0, 0);
column_set->AddPaddingColumn(0, kRelatedControlHorizontalSpacing);
@@ -138,14 +143,19 @@
GridLayout::USE_PREF, 0, 0);
// Fill the grid.
- layout->StartRow(0, column_set_id);
- layout->AddView(table_view_, 1, 4, GridLayout::FILL,
+ layout->StartRow(0, top_column_set_id);
+ layout->AddView(table_view_, 1, 6, GridLayout::FILL,
GridLayout::FILL);
layout->AddView(&remove_button_);
- layout->StartRowWithPadding(0, column_set_id, 0,
+ layout->StartRowWithPadding(0, top_column_set_id, 0,
kRelatedControlVerticalSpacing);
layout->SkipColumns(1);
layout->AddView(&remove_all_button_);
+ layout->StartRowWithPadding(0, top_column_set_id, 0,
+ kRelatedControlVerticalSpacing);
+
+ layout->SkipColumns(1);
+ layout->AddView(&show_button_);
layout->AddPaddingRow(1, 0);
// Ask the database for exception data.
@@ -155,11 +165,16 @@
///////////////////////////////////////////////////////////////////////////////
// ExceptionsPageView, private
void ExceptionsPageView::SetupButtons() {
+ // Disable all buttons in the first place.
remove_button_.SetParentOwned(false);
remove_button_.SetEnabled(false);
remove_all_button_.SetParentOwned(false);
remove_all_button_.SetEnabled(false);
+
+ show_button_.SetParentOwned(false);
+ show_button_.SetEnabled(false);
+ show_button_.SetVisible(false);
}
void ExceptionsPageView::SetupTable() {
@@ -169,9 +184,8 @@
// Creates the different columns for the table.
// The float resize values are the result of much tinkering.
std::vector<TableColumn> columns;
- columns.push_back(TableColumn(
- IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN,
- TableColumn::LEFT, -1, 0.55f));
+ columns.push_back(TableColumn(IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN,
+ TableColumn::LEFT, -1, 0.55f));
columns.back().sortable = true;
table_view_ = new views::TableView(&table_model_, columns, views::TEXT_ONLY,
true, true, true);
« no previous file with comments | « chrome/browser/views/options/exceptions_page_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698