Blink Platform: Remove time functions from Platform.

content/renderer/renderer_blink_platform_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_blink_platform_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/location.h"
@@ skipping 263 matching lines @@
 #if !defined(OS_ANDROID) && !defined(OS_WIN)
   // SandboxSupport contains a map of WebFontFamily objects, which hold
   // WebCStrings, which become invalidated when blink is shut down. Hence, we
   // need to clear that map now, just before blink::shutdown() is called.
   sandbox_support_.reset();
 #endif
 }
 
 //------------------------------------------------------------------------------
 
-double RendererBlinkPlatformImpl::currentTimeSeconds() {
-  return renderer_scheduler_->CurrentTimeSeconds();
-}
-
-double RendererBlinkPlatformImpl::monotonicallyIncreasingTimeSeconds() {
-  return renderer_scheduler_->MonotonicallyIncreasingTimeSeconds();

[esprehn, 2016/01/05 07:01:09]

The scheduler implements virtual time, where is that done now?

[Yuta Kitamura, 2016/01/05 09:17:46]

Good point. This was my oversight, but after looking at some
scheduler code I started to wonder if the ability to take over
Blink's clock for schedulers was really necessary.

The production implementation of CurrentTimeSeconds() is
base::Time::Now().ToDoubleT() which is same as what my patch
does, thus the sole purpose of this hijacking is for testing.
However, according to my try results, all try bots are green.
So...?

I think I need some wisdom from the author of this code about
the real intent of this... alexclarke, WDYT?

If we really need this ability, we may have to make rather
intrusive API so the modules outside Blink can control Blink's
clock, or otherwise leave the Platform interface as is.

[alex clarke (OOO till 29th), 2016/01/05 10:49:24]

This is for Headless Chrome
(https://docs.google.com/document/d/1dIMHIl1xutUXqXWRXqXrDd3bo9hachIt_ZkPK_Bsh...)
We don't have good integration testing for this (yet) sadly.
For Headless parts of blink need the real clock still but most of it needs the
virtual clock.  I don't have a strong opinion on how this stuff should be wired
up so if there's something we can do that fits in better with Onion Soup then we
should explore that.

We'd be happy to talk about this over VC.

-}
-
-//------------------------------------------------------------------------------
-
 blink::WebURLLoader* RendererBlinkPlatformImpl::createURLLoader() {
   ChildThreadImpl* child_thread = ChildThreadImpl::current();
   // There may be no child thread in RenderViewTests.  These tests can still use
   // data URLs to bypass the ResourceDispatcher.
   scoped_ptr<scheduler::WebTaskRunnerImpl> task_runner(
       new scheduler::WebTaskRunnerImpl(
         loading_task_runner_->BelongsToCurrentThread()
             ? loading_task_runner_ : base::ThreadTaskRunnerHandle::Get()));
   return new content::WebURLLoaderImpl(
       child_thread ? child_thread->resource_dispatcher() : NULL,
@@ skipping 984 matching lines @@
 //------------------------------------------------------------------------------
 
 void RendererBlinkPlatformImpl::MockBatteryStatusChangedForTesting(
     const blink::WebBatteryStatus& status) {
   if (!g_test_battery_status_listener)
     return;
   g_test_battery_status_listener->updateBatteryStatus(status);
 }
 
 }  // namespace content