Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1550533002: Rename WorkerGlobalScopeExecutionState to ExecutionState. (Closed)

Created:
4 years, 12 months ago by ikilpatrick
Modified:
4 years, 12 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WorkerGlobalScopeExecutionState to ExecutionState. As per https://codereview.chromium.org/1535943005/ in preparation for renaming WorkerScriptController to IsolatedScriptController. BUG=567358 Committed: https://crrev.com/5ec7646c06c3266f27ae291db023e006190cc1cc Cr-Commit-Position: refs/heads/master@{#366854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.h View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp View 6 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ikilpatrick
4 years, 12 months ago (2015-12-24 17:21:55 UTC) #3
kinuko
lgtm
4 years, 12 months ago (2015-12-25 02:37:30 UTC) #4
kinuko
+haraken for bindings/ owner review
4 years, 12 months ago (2015-12-25 02:38:51 UTC) #6
haraken
bindings/ LGTM
4 years, 12 months ago (2015-12-25 04:01:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550533002/1
4 years, 12 months ago (2015-12-25 04:23:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-25 04:29:19 UTC) #11
commit-bot: I haz the power
4 years, 12 months ago (2015-12-25 04:30:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ec7646c06c3266f27ae291db023e006190cc1cc
Cr-Commit-Position: refs/heads/master@{#366854}

Powered by Google App Engine
This is Rietveld 408576698