Scroll-wheeling, whilst over the tab-strip, now switches tabs on GTK/Linux.

Scroll-wheeling, whilst over the tab-strip, now switches tabs on GTK/Linux.

TEST=none
BUG=1316

[Nigel Tao, 2009-07-03 13:22:19]

This is my first chromium review, but I have skipped the AUTHORS file as I am
wearing my Google employee hat.

Note that this change only affects the GTK port, not other platforms.

[Nigel Tao, 2009-07-03 13:38:42]

Ah, I did a "gcl upload", and now "gcl opened" is reporting no files are opened.
Is this normal or did I do something wrong (I was futzing around with gclient
commands, like "gclient status", around the same time)?

Anyway, the "+#include "base/gfx/gtk_util.h"" in the .cc file is spurious, a
leftover from some set-background-color debugging.

[Evan Martin, 2009-07-03 16:06:26]

+tab strip master

[James Hawkins, 2009-07-06 18:13:49]

On 2009/07/03 16:06:26, Evan Martin wrote:
> +tab strip master

What is the motivation for this change?  This feature isn't in Chrome for
Windows or Firefox for Linux.

[Nigel Tao, 2009-07-07 12:25:45]

On 2009/07/06 18:13:49, James Hawkins wrote:
> On 2009/07/03 16:06:26, Evan Martin wrote:
> > +tab strip master
> 
> What is the motivation for this change?  This feature isn't in Chrome for
> Windows or Firefox for Linux.

As mentioned in the bug report (1), this is indeed not native Windows behavior,
but it is native GTK behavior. For example, the GNOME text editor (gedit),
browser (epiphany), and terminal emulator (gnome-terminal) all change tabs when
scroll-wheeling over the tab-strip. The fact that Firefox (for Linux) does not
makes Firefox feel (to me) less like the rest of my desktop.

(1) http://code.google.com/p/chromium/issues/detail?id=1316

[Evan Martin, 2009-07-09 19:01:52]

I think we should land this.  All apps do this.  Even our own options dialog, by
virtue of using a native tab control, does this.

James, any retort?  :)

[James Hawkins, 2009-07-09 19:22:23]

On 2009/07/09 19:01:52, Evan Martin wrote:
> I think we should land this.  All apps do this.  Even our own options dialog,
by
> virtue of using a native tab control, does this.
> 
> James, any retort?  :)

LGTM

[James Hawkins, 2009-07-09 19:32:31]

On 2009/07/09 19:22:23, James Hawkins wrote:
> On 2009/07/09 19:01:52, Evan Martin wrote:
> > I think we should land this.  All apps do this.  Even our own options
dialog,
> by
> > virtue of using a native tab control, does this.
> > 
> > James, any retort?  :)
> 
> LGTM

This is r20297.  I added 'Patch by Nigel Tao' to the description, but that
somehow didn't get picked up :-/ Sorry about that.

[tony, 2009-07-09 21:12:32]

BTW, this seems a bit different than the native gtk+ tabs.  On Gtk+, it doesn't
wrap around but on the chrome tab strip, it does.