Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 155053: Scroll-wheeling, whilst over the tab-strip, now switches tabs on GTK/Linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by Nigel Tao
Modified:
6 years, 3 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Scroll-wheeling, whilst over the tab-strip, now switches tabs on GTK/Linux. TEST=none BUG=1316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M chrome/browser/gtk/browser_titlebar.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 6 chunks +28 lines, -5 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (0 generated)
Nigel Tao
This is my first chromium review, but I have skipped the AUTHORS file as I ...
8 years, 1 month ago (2009-07-03 13:22:19 UTC) #1
Nigel Tao
Ah, I did a "gcl upload", and now "gcl opened" is reporting no files are ...
8 years, 1 month ago (2009-07-03 13:38:42 UTC) #2
Evan Martin
+tab strip master
8 years, 1 month ago (2009-07-03 16:06:26 UTC) #3
James Hawkins
On 2009/07/03 16:06:26, Evan Martin wrote: > +tab strip master What is the motivation for ...
8 years, 1 month ago (2009-07-06 18:13:49 UTC) #4
Nigel Tao
On 2009/07/06 18:13:49, James Hawkins wrote: > On 2009/07/03 16:06:26, Evan Martin wrote: > > ...
8 years, 1 month ago (2009-07-07 12:25:45 UTC) #5
Evan Martin
I think we should land this. All apps do this. Even our own options dialog, ...
8 years, 1 month ago (2009-07-09 19:01:52 UTC) #6
James Hawkins
On 2009/07/09 19:01:52, Evan Martin wrote: > I think we should land this. All apps ...
8 years, 1 month ago (2009-07-09 19:22:23 UTC) #7
James Hawkins
On 2009/07/09 19:22:23, James Hawkins wrote: > On 2009/07/09 19:01:52, Evan Martin wrote: > > ...
8 years, 1 month ago (2009-07-09 19:32:31 UTC) #8
tony
8 years, 1 month ago (2009-07-09 21:12:32 UTC) #9
BTW, this seems a bit different than the native gtk+ tabs.  On Gtk+, it doesn't
wrap around but on the chrome tab strip, it does.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b