third_party/WebKit/PerformanceTests/Layout/attach-inlines.html - Issue 1550513003: Skip dirtying lines when attaching children prior to attaching oneself

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/PerformanceTests/Layout/attach-inlines.html

Issue 1550513003: Skip dirtying lines when attaching children prior to attaching oneself (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skip dirtying lines when attaching children prior to attaching oneself Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div id="div" style="display: none;">

	3 <span id="span"></span>

	4 </div>

	5 <script src="../resources/runner.js"></script>

	6 <script>

	7 var div = document.getElementById("div");

	8 var style = div.style;

	9

	10 function createInlines() {

	11 var innerHTML = "<span>Text</span>";
	esprehn 2016/07/18 22:16:51 innerHTML = "<span>Text</span>".repeat(N); innerHTML = "<span>Text</span>".repeat(N);
	12 for (var x = 0; x < 500; ++x){

	13 innerHTML = innerHTML + "<span>Text</span>";
	esprehn 2016/07/18 22:16:51 this is making it exponentially bigger btw, lets j this is making it exponentially bigger btw, lets just use a real number in repeat()
	14 }

	15 return innerHTML;

	16 }

	17

	18 var originalLines = createInlines();

	19 span.innerHTML = originalLines;
	esprehn 2016/07/18 22:16:51 do all mutations inside the test do all mutations inside the test
	20

	21 function test() {

	22 style.display = "block";

	23 PerfTestRunner.forceLayout();

	24

	25 span.innerHTML += originalLines;
	esprehn 2016/07/18 22:16:51 This is measuring the performance of serializing t This is measuring the performance of serializing tons of spans and then innerHTML'ing tons and tons of them. I'm not sure if that's what you what to benchmark. Using += like this is also very sketchy, I see you reset the test below.
	26 PerfTestRunner.forceLayout();

	27

	28 style.display = "none";

	29 span.innerHTML = originalLines;

	30 PerfTestRunner.forceLayout();

	31 }

	32

	33 PerfTestRunner.measureRunsPerSecond({

	34 description: "Measures performance of attaching a large number of inline s to an inline.",

	35 run: test

	36 });

	37 </script>

	38 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/line/LineBoxList.cpp » ('j') | no next file with comments »