The chrome browser target should not depend on plugins.

webkit/common/plugins/ppapi/ppapi_utils.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#include "webkit/common/plugins/ppapi/ppapi_utils.h"
+
+#include "ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h"
+#include "ppapi/c/dev/ppb_var_deprecated.h"
+#include "ppapi/c/ppb_core.h"
+#include "ppapi/c/ppb_input_event.h"
+#include "ppapi/c/ppb_var.h"
+#include "ppapi/c/ppb_var_array_buffer.h"
+#include "ppapi/c/private/ppb_content_decryptor_private.h"
+#include "ppapi/c/private/ppb_gpu_blacklist_private.h"
+#include "ppapi/c/private/ppb_proxy_private.h"
+#include "ppapi/c/private/ppb_uma_private.h"
+#include "ppapi/thunk/thunk.h"
+
+namespace webkit {
+namespace ppapi {
+
+bool IsSupportedPepperInterface(const char* name) {

[raymes1, 2013/05/21 15:46:29]

I misunderstood slightly what you meant. This won't work completely because you
still need the part which says:

  // TODO(brettw) put these in a hash map for better performance.
  #define UNPROXIED_IFACE(api_name, iface_str, iface_struct) \
      if (strcmp(name, iface_str) == 0) \
        return ::ppapi::thunk::Get##iface_struct##_Thunk();
  #define PROXIED_IFACE(api_name, iface_str, iface_struct) \
      UNPROXIED_IFACE(api_name, iface_str, iface_struct)

  #include "ppapi/thunk/interfaces_ppb_public_stable.h"
  #include "ppapi/thunk/interfaces_ppb_public_dev.h"
  #include "ppapi/thunk/interfaces_ppb_private.h"
  #include "ppapi/thunk/interfaces_ppb_private_no_permissions.h"
  #include "ppapi/thunk/interfaces_ppb_private_flash.h"

  #undef UNPROXIED_API
  #undef PROXIED_IFACE

Is there a problem including that part?

Also if we move this stuff, PluginModule::InternalGetInterface() should call
into this function to avoid code duplication.

[ananta, 2013/05/21 19:20:37]

I added the required section back. We cannot share the whole code sadly because
the InternalGetInterface function refers to structures and code inside
webkit/plugins/ppapi which won't work here. Added a TODO to this effect.

+  // Please keep alphabetized by interface macro name with "special" stuff at
+  // the bottom.
+  if (strcmp(name, PPB_AUDIO_TRUSTED_INTERFACE_0_6) == 0)

[jamesr, 2013/05/20 23:42:30]

think you need #include <cstring> for this to compile everywhere

[ananta, 2013/05/21 19:20:37]

Done.

+    return true;
+  if (strcmp(name, PPB_BUFFER_TRUSTED_INTERFACE_0_1) == 0)
+    return true;
+  if (strcmp(name, PPB_CORE_INTERFACE_1_0) == 0)
+    return true;
+  if (strcmp(name, PPB_GPUBLACKLIST_PRIVATE_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_GRAPHICS_3D_TRUSTED_INTERFACE_1_0) == 0)
+    return true;
+  if (strcmp(name, PPB_IMAGEDATA_TRUSTED_INTERFACE_0_4) == 0)
+    return true;
+  if (strcmp(name, PPB_INPUT_EVENT_INTERFACE_1_0) == 0)
+    return true;
+  if (strcmp(name, PPB_INSTANCE_PRIVATE_INTERFACE_0_1) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_INSTANCEDARRAYS_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_FRAMEBUFFERBLIT_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_FRAMEBUFFERMULTISAMPLE_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_CHROMIUMENABLEFEATURE_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_CHROMIUMMAPSUB_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_CHROMIUMMAPSUB_DEV_INTERFACE_1_0) == 0)
+    return true;
+  if (strcmp(name, PPB_OPENGLES2_QUERY_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_PROXY_PRIVATE_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_UMA_PRIVATE_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_VAR_DEPRECATED_INTERFACE) == 0)
+    return true;
+  if (strcmp(name, PPB_VAR_INTERFACE_1_0) == 0)
+    return true;
+  if (strcmp(name, PPB_VAR_INTERFACE_1_1) == 0)
+    return true;
+  if (strcmp(name, PPB_VAR_ARRAY_BUFFER_INTERFACE_1_0) == 0)
+    return true;
+  return false;
+}
+
+}  // namespace ppapi
+}  // namespace webkit