GTTF: Convert most tests in content to use EmbeddedTestServer.

net/test/embedded_test_server/http_response.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TEST_EMBEDDED_TEST_SERVER_HTTP_RESPONSE_H_
 #define NET_TEST_EMBEDDED_TEST_SERVER_HTTP_RESPONSE_H_
 
 #include <map>
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/compiler_specific.h"
 
 namespace net {
 namespace test_server {
 
 enum ResponseCode {
   SUCCESS = 200,
   CREATED = 201,
   NO_CONTENT = 204,
   MOVED = 301,
   RESUME_INCOMPLETE = 308,
   NOT_FOUND = 404,
   PRECONDITION = 412,
   ACCESS_DENIED = 500,
 };
 
-// Respresents a HTTP response. Since it can be big, it may be better to use
-// scoped_ptr to pass it instead of copying.
+// Respresents a HTTP response.

[Avi (use Gerrit), 2013/05/21 00:24:22]

fix typo

[Paweł Hajdan Jr., 2013/05/21 17:56:03]

Done.

 class HttpResponse {
  public:
-  HttpResponse();
-  ~HttpResponse();
+  virtual ~HttpResponse();
+
+  virtual std::string ToResponseString() const = 0;

[satorux1, 2013/05/21 07:40:18]

function comment is missing. maybe:

// Returns a HTTP response which starts from "HTTP/x.x" line,
// followed by response headers like "Content-Type: text/html".

[Paweł Hajdan Jr., 2013/05/21 17:56:03]

Updated. Note that one of the implementations deliberately returns an empty
string there to trigger ERR_EMPTY_RESPONSE, so my actual comment reflects that.

+};
+
+class HttpResponseImpl : public HttpResponse {

[satorux1, 2013/05/21 07:40:18]

I found this name unusual. Usually classes named "Impl" are implementation
details thus not used as a public API (they are often defined in .cc file).

Maybe:

// Interface for HTTP response implementations.
class HttpResponseInterface {
  ...

  virtual std::string ToResponseString() const = 0;
}

// This class is used to handle basic HTTP responses with commonly used
// response headers such as "Content-Type".
class HttpResponse : public HttpResponseInterface {
  ...
}

This way, you don't have to touch the existing code. 

[Paweł Hajdan Jr., 2013/05/21 17:56:03]

Done.

+ public:
+  HttpResponseImpl();
+  ~HttpResponseImpl();
 
   // The response code.
   ResponseCode code() const { return code_; }
   void set_code(ResponseCode code) { code_ = code; }
 
   // The content of the response.
   const std::string& content() const { return content_; }
   void set_content(const std::string& content) { content_ = content; }
 
   // The content type.
   const std::string& content_type() const { return content_type_; }
   void set_content_type(const std::string& content_type) {
     content_type_ = content_type;
   }
 
   // The custom headers to be sent to the client.
   const std::map<std::string, std::string>& custom_headers() const {
     return custom_headers_;
   }
 
   // Adds a custom header.
   void AddCustomHeader(const std::string& key, const std::string& value) {
     custom_headers_[key] = value;
   }
 
   // Generates and returns a http response string.
-  std::string ToResponseString() const;
+  virtual std::string ToResponseString() const OVERRIDE;
 
  private:
   ResponseCode code_;
   std::string content_;
   std::string content_type_;
   std::map<std::string, std::string> custom_headers_;
+
+  DISALLOW_COPY_AND_ASSIGN(HttpResponseImpl);
 };
 
 }  // namespace test_server
 }  // namespace net
 
 #endif  // NET_TEST_EMBEDDED_TEST_SERVER_HTTP_RESPONSE_H_