Better NullCheck for null-or-number

Better NullCheck for null-or-number

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/712574058a9ce5e8fdbd23e27b9d6b13b84debf2

[sra1, 2015-12-23 22:14:07]

Patchset #1 (id:1) has been deleted

[sra1, 2015-12-23 22:14:16]

Patchset #1 (id:20001) has been deleted

[sra1, 2015-12-23 22:17:15]

Patchset #1 (id:40001) has been deleted

[sra1, 2015-12-23 22:44:42]

sra@google.com changed reviewers:
+ kmillikin@google.com

[sra1, 2015-12-23 22:44:42]

Brings QuickSort / TreeSort / NavierStokes benchmarks up to SSA performance. 
BubbleSort is improved 115% but still behind.

[sra1, 2015-12-23 22:45:16]

Patchset #1 (id:60001) has been deleted

[sra1, 2015-12-23 22:54:12]

On 2015/12/23 22:44:42, sra1 wrote:
> Brings QuickSort / TreeSort / NavierStokes benchmarks up to SSA performance. 
> BubbleSort is improved 115% but still behind.

BubbleSort is behind because the inlined `JSNumber.>` code does:

          if (typeof n !== "number")
            throw H.wrapException(H.argumentErrorValue(n));

but the specially inserted arguemnt check in SSA does

          if (typeof n !== "number")
            return H.iae(n);

This is a V8 issue, firefox js runs both at the same speed, faster than V8.

From a code-size perspective it might be worth detecting all code that
effectively does `throw new ArgumentError.value(x)` and outlining it via `return
$.iae(x)`, i.e. replace SSA's special technique with a general technique.

[Harry Terkelsen, 2015-12-28 19:30:40]

het@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2015-12-28 19:30:41]

lgtm

https://codereview.chromium.org/1550463002/diff/80001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/inline.dart (right):

https://codereview.chromium.org/1550463002/diff/80001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/inline.dart:460: Selector selector = invoke is
InvokeMethod ? invoke.selector : null;
maybe move inside the "if" since that is the only place selector is used?

[sra1, 2015-12-28 20:06:26]

Description was changed from

==========
Better NullCheck for null-or-number
==========

to

==========
Better NullCheck for null-or-number

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/712574058a9ce5e8fdbd23e27b9d6b13b84debf2
==========

[sra1, 2015-12-28 20:06:29]

Committed patchset #1 (id:80001) manually as
712574058a9ce5e8fdbd23e27b9d6b13b84debf2 (presubmit successful).