Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5794)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.h

Issue 1550443002: Pushed InkDropHost inheritence up to CustomButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_button.h
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.h b/chrome/browser/ui/views/toolbar/toolbar_button.h
index 637d31a52fa68cab6bca512c644aa74644f55d9c..bf6e5e018821c803e450d9568142796dff3592ac 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.h
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.h
@@ -8,7 +8,6 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "ui/gfx/geometry/point.h"
-#include "ui/views/animation/ink_drop_host.h"
#include "ui/views/context_menu_controller.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/button/label_button.h"
@@ -27,8 +26,7 @@ class MenuRunner;
// This class provides basic drawing and mouse-over behavior for buttons
// appearing in the toolbar.
class ToolbarButton : public views::LabelButton,
- public views::ContextMenuController,
- public views::InkDropHost {
+ public views::ContextMenuController {
public:
// Takes ownership of the |model|, which can be null if no menu
// is to be shown.
@@ -56,16 +54,14 @@ class ToolbarButton : public views::LabelButton,
void OnGestureEvent(ui::GestureEvent* event) override;
void GetAccessibleState(ui::AXViewState* state) override;
scoped_ptr<views::LabelButtonBorder> CreateDefaultBorder() const override;
+ void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
+ void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
// views::ContextMenuController:
void ShowContextMenuForView(View* source,
const gfx::Point& point,
ui::MenuSourceType source_type) override;
- // views::InkDropHost:
- void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
- void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
-
protected:
// views::LabelButton:
bool ShouldEnterPushedState(const ui::Event& event) override;
@@ -80,9 +76,6 @@ class ToolbarButton : public views::LabelButton,
// views::LabelButton:
const char* GetClassName() const override;
- // views::InkDropHost:
- gfx::Point CalculateInkDropCenter() const override;
-
// The associated profile. The browser theme affects rendering.
Profile* profile_;
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698