Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 1550443002: Pushed InkDropHost inheritence up to CustomButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed whitespace in toolbar_action_view.h Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_button.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc
index 06c08fe1b019921e237fa507fa95cb1fb75640f6..8c16229931f58819dfb64f5cc313b7dfc02f835d 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc
@@ -174,32 +174,26 @@ ToolbarButton::CreateDefaultBorder() const {
return border;
}
-void ToolbarButton::ShowContextMenuForView(View* source,
- const gfx::Point& point,
- ui::MenuSourceType source_type) {
- if (!enabled())
- return;
-
- show_menu_factory_.InvalidateWeakPtrs();
- ShowDropDownMenu(source_type);
-}
-
void ToolbarButton::AddInkDropLayer(ui::Layer* ink_drop_layer) {
- SetPaintToLayer(true);
- SetFillsBoundsOpaquely(false);
image()->SetPaintToLayer(true);
image()->SetFillsBoundsOpaquely(false);
-
- layer()->Add(ink_drop_layer);
- layer()->StackAtBottom(ink_drop_layer);
+ views::LabelButton::AddInkDropLayer(ink_drop_layer);
}
void ToolbarButton::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {
- layer()->Remove(ink_drop_layer);
-
+ views::LabelButton::RemoveInkDropLayer(ink_drop_layer);
image()->SetFillsBoundsOpaquely(true);
image()->SetPaintToLayer(false);
- SetPaintToLayer(false);
+}
+
+void ToolbarButton::ShowContextMenuForView(View* source,
+ const gfx::Point& point,
+ ui::MenuSourceType source_type) {
+ if (!enabled())
+ return;
+
+ show_menu_factory_.InvalidateWeakPtrs();
+ ShowDropDownMenu(source_type);
}
bool ToolbarButton::ShouldEnterPushedState(const ui::Event& event) {
@@ -298,7 +292,3 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {
const char* ToolbarButton::GetClassName() const {
return "ToolbarButton";
}
-
-gfx::Point ToolbarButton::CalculateInkDropCenter() const {
- return GetLocalBounds().CenterPoint();
-}

Powered by Google App Engine
This is Rietveld 408576698