ui/views/animation/ink_drop_host.cc - Issue 1550443002: Pushed InkDropHost inheritence up to CustomButton.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/animation/ink_drop_host.cc

Issue 1550443002: Pushed InkDropHost inheritence up to CustomButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed doc typo. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/views/animation/ink_drop_host.h"

	6

	7 namespace views {

	8

	9 InkDropHost::InkDropHost() {}

	10

	11 InkDropHost::~InkDropHost() {}

	12

	13 void InkDropHost::AddInkDropLayer(ui::Layer* ink_drop_layer) {}

	14

	15 void InkDropHost::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {}
	Evan Stade 2015/12/29 23:03:37 p.s. why did you add this default impl instead of p.s. why did you add this default impl instead of making CustomButton have a default do-nothing impl? pure virtual is generally preferable Evan Stade 2015/12/29 23:06:56 ah, I see this was suggested by Peter. I prefer pu Show quoted text On 2015/12/29 23:03:37, Evan Stade wrote: > p.s. why did you add this default impl instead of making CustomButton have a > default do-nothing impl? pure virtual is generally preferable ah, I see this was suggested by Peter. I prefer pure virtual in this situation, but perhaps it's a policy decision that has been made at a broader level. It seems like the Google C++ style guide forbids multiple inheritance (excluding pure virtual interfaces), but admittedly that's not followed everywhere in Chrome.
	16

	17 } // namespace views

OLD	NEW

« no previous file with comments | « ui/views/animation/ink_drop_host.h ('k') | ui/views/controls/button/custom_button.h » ('j') | no next file with comments »