Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1550423002: Autoclose Media Router dialog depending on mouse position 3s after route creation/close. (Closed)

Created:
4 years, 11 months ago by apacible
Modified:
4 years, 11 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org, amp
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autoclose Media Router dialog depending on mouse position 3s after route creation/close. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 Committed: https://crrev.com/ee72c7188d6b5d35f84cc4c7bdb22210eb9f424b Cr-Commit-Position: refs/heads/master@{#367548}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -34 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 6 chunks +33 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
apacible
We haven't finalized the behavior for the dialog closing, but here's some changes for my ...
4 years, 11 months ago (2015-12-31 02:12:21 UTC) #9
imcheng
lgtm
4 years, 11 months ago (2016-01-05 01:48:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550423002/40001
4 years, 11 months ago (2016-01-05 16:01:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 11 months ago (2016-01-05 16:37:11 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 16:38:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee72c7188d6b5d35f84cc4c7bdb22210eb9f424b
Cr-Commit-Position: refs/heads/master@{#367548}

Powered by Google App Engine
This is Rietveld 408576698