|
|
Chromium Code Reviews|
Created:
4 years, 11 months ago by apacible Modified:
4 years, 11 months ago Reviewers:
imcheng CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org, amp Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAutoclose Media Router dialog depending on mouse position 3s after route creation/close.
Behavior:
1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s)
2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes.
3. If you hadn't taken an action and move the mouse off the dialog, nothing happens.
The 3s timer starts when the action is triggered, which is the same as the current start time now.
BUG=573299
Committed: https://crrev.com/ee72c7188d6b5d35f84cc4c7bdb22210eb9f424b
Cr-Commit-Position: refs/heads/master@{#367548}
Patch Set 1 : #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== autoclose dialog when mouseleave BUG= ========== to ========== [Work In Progress] Close Media Router dialog after 3s if the mouse isn't hovering over it. ==========
Description was changed from ========== [Work In Progress] Close Media Router dialog after 3s if the mouse isn't hovering over it. ========== to ========== [Work In Progress] Close Media Router dialog after 3s if the mouse isn't hovering over it. BUG=573299 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [Work In Progress] Close Media Router dialog after 3s if the mouse isn't hovering over it. BUG=573299 ========== to ========== Close Media Router dialog if the mouse isn't hovering over it after 3s. BUG=573299 ==========
Description was changed from ========== Close Media Router dialog if the mouse isn't hovering over it after 3s. BUG=573299 ========== to ========== Close Media Router dialog if the mouse isn't hovering over it after 3s. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 ==========
Description was changed from ========== Close Media Router dialog if the mouse isn't hovering over it after 3s. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 ========== to ========== Autoclose Media Router dialog depending on mouse position 3s after route creation/close. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 ==========
apacible@chromium.org changed reviewers: + imcheng@chromium.org
We haven't finalized the behavior for the dialog closing, but here's some changes for my latest proposal in regards to mouse position determining if we auto-close the dialog after an action (close/create route). You can also patch it locally to see how the behavior feels. PTAL, thanks!
lgtm
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550423002/40001
Message was sent while issue was closed.
Description was changed from ========== Autoclose Media Router dialog depending on mouse position 3s after route creation/close. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 ========== to ========== Autoclose Media Router dialog depending on mouse position 3s after route creation/close. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Autoclose Media Router dialog depending on mouse position 3s after route creation/close. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 ========== to ========== Autoclose Media Router dialog depending on mouse position 3s after route creation/close. Behavior: 1. If you take an action (start or close route), 3s passes and the mouse is on the dialog, the timer is cancelled and dialog stays open. (two cases: keep your mouse on the dialog, and move mouse off dialog and back to dialog within the 3s) 2. If you take an action, move your mouse off the dialog, and 3s passes, the timer expires and the dialog closes. 3. If you hadn't taken an action and move the mouse off the dialog, nothing happens. The 3s timer starts when the action is triggered, which is the same as the current start time now. BUG=573299 Committed: https://crrev.com/ee72c7188d6b5d35f84cc4c7bdb22210eb9f424b Cr-Commit-Position: refs/heads/master@{#367548} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ee72c7188d6b5d35f84cc4c7bdb22210eb9f424b Cr-Commit-Position: refs/heads/master@{#367548} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
