Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550393002: Rename conversions.cpp to utilities.cpp (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
Daniel Nishi, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename conversions.cpp to utilities.cpp conversions.cpp already contains utility functions not related to V8 value conversions. BUG= Committed: https://crrev.com/6248141aeb1a9475792ab0bc25663f2489f41a08 Cr-Commit-Position: refs/heads/master@{#367147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -67 lines) Patch
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/conversions.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/union.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/bindings/templates/utilities.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years, 11 months ago (2015-12-30 00:31:59 UTC) #2
sof
lgtm
4 years, 11 months ago (2015-12-30 06:30:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550393002/1
4 years, 11 months ago (2015-12-30 07:50:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 09:05:03 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 09:06:10 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6248141aeb1a9475792ab0bc25663f2489f41a08
Cr-Commit-Position: refs/heads/master@{#367147}

Powered by Google App Engine
This is Rietveld 408576698