Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1550313002: Reland of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (Closed)

Created:
4 years, 11 months ago by fmeawad
Modified:
4 years, 11 months ago
Reviewers:
nednguyen, llozano
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (patchset #1 id:1 of https://codereview.chromium.org/1557473002/ ) Reason for revert: Sorry I do not think this is the culprit CL anymore, relanding. Original issue's description: > Revert of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (patchset #1 id:2 of https://codereview.chromium.org/1556463002/ ) > > Reason for revert: > Speculative revert: > Failed power benchmarks on N5 > > See https://code.google.com/p/chromium/issues/detail?id=572954 for details. > > BUG=572954 > > Original issue's description: > > Fix bootstraps_deps of tools/perf to include build/android/pylib/. > > > > After John's work in crbug.com/560559, telemetry project no longer depends > > on pylib, hence tools/perf which is a user of telemetry must specify this > > deps explictly. > > > > BUG=572700, 560559 > > TBR=jbudorick@chromium.org > > > > Committed: https://crrev.com/89fe15bf1183cd781a6d27983e7ce792f4641e88 > > Cr-Commit-Position: refs/heads/master@{#367045} > > TBR=llozano@chromium.org,nednguyen@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=572700, 560559 > > Committed: https://crrev.com/5fc45b53137022c58150279fb62a0c2ef18bff80 > Cr-Commit-Position: refs/heads/master@{#367088} TBR=llozano@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=572954 Committed: https://crrev.com/fe7cb176719f2092a29d6940f549fcf75cdb36b2 Cr-Commit-Position: refs/heads/master@{#367090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/bootstrap_deps View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fmeawad
Created Reland of Fix bootstraps_deps of tools/perf to include build/android/pylib/.
4 years, 11 months ago (2015-12-29 19:11:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550313002/1
4 years, 11 months ago (2015-12-29 19:11:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 19:12:33 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 19:13:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe7cb176719f2092a29d6940f549fcf75cdb36b2
Cr-Commit-Position: refs/heads/master@{#367090}

Powered by Google App Engine
This is Rietveld 408576698