Intrinsify random nextState, improve perfromance significantly.

runtime/lib/math_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:typed_data";
 
 // A VM patch of the dart:math library.
 
 // If [x] is an [int] and [exponent] is a non-negative [int], the result is
 // an [int], otherwise the result is a [double].
@@ skipping 50 matching lines @@
   static const kSTATE_HI = 1;
 
   _Random._internal(state) {
     _state[kSTATE_LO] = state & _MASK_32;
     _state[kSTATE_HI] = state >> 32;
   }
 
   // The algorithm used here is Multiply with Carry (MWC) with a Base b = 2^32.
   // http://en.wikipedia.org/wiki/Multiply-with-carry
   // The constant A is selected from "Numerical Recipes 3rd Edition" p.348 B1.
-  int _nextInt32() {
+  int _nextState() {

[zra, 2013/05/20 23:38:17]

return type should be void?

[srdjan, 2013/05/20 23:48:25]

Done.

     var state = ((_A * (_state[kSTATE_LO])) + _state[kSTATE_HI]) & _MASK_64;
     _state[kSTATE_LO] = state & _MASK_32;
     _state[kSTATE_HI] = state >> 32;
-    return _state[kSTATE_LO];
   }
 
   int nextInt(int max) {
-    if (max <= 0 || max > _POW2_32) {
+    // TODO(srdjan): Remove the 'limit' check once optimizing  comparison of
+    // Smi-s with Mint constants.
+    final limit = 0x3FFFFFFF;
+    if (max <= 0 || ((max > limit) && (max > _POW2_32))) {
       throw new ArgumentError("max must be positive and < 2^32:"
                                          " $max");
     }
     if ((max & -max) == max) {
       // Fast case for powers of two.
-      return _nextInt32() & (max - 1);
+      _nextState();
+      return _state[kSTATE_LO] & (max - 1);
     }
 
     var rnd32;
     var result;
     do {
-      rnd32 = _nextInt32();
+      _nextState();
+      rnd32 = _state[kSTATE_LO];
       result = rnd32 % max;
     } while ((rnd32 - result + max) >= _POW2_32);
     return result;
   }
 
   double nextDouble() {
     return ((nextInt(1 << 26) << 27) + nextInt(1 << 27)) / _POW2_53_D;
   }
 
   bool nextBool() {
@@ skipping 10 matching lines @@
 
   // Use a singleton Random object to get a new seed if no seed was passed.
   static var _prng = null;
 
   static int _nextSeed() {
     if (_prng == null) {
       // TODO(iposva): Use system to get a random seed.
       _prng = new Random(new DateTime.now().millisecondsSinceEpoch);
     }
     // Trigger the PRNG once to change the internal state.
-    return _prng._nextInt32();
+    _prng._nextState();
+    return _prng._state[kSTATE_LO];
   }
 }