Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1550193002: Simplify PDFiumEngine::CheckPageAvailable().

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 12 months ago
Reviewers:
spelchat
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdfload
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify PDFiumEngine::CheckPageAvailable(). Also: - Always check the return value from FPDFAvail_IsPageAvail(). - Change PDFiumPage::set_available(bool) to set_as_available().

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 2 chunks +16 lines, -13 lines 0 comments Download
M pdf/pdfium/pdfium_page.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 12 months ago (2015-12-29 01:04:28 UTC) #3
spelchat
lgtm
4 years, 12 months ago (2015-12-29 01:18:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550193002/20001
4 years, 12 months ago (2015-12-29 03:42:06 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 04:22:40 UTC) #8
Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698