Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550113002: [d8] Add support for printing symbols (Closed)

Created:
4 years, 12 months ago by Camillo Bruni
Modified:
4 years, 12 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Add support for printing symbols BUG= Committed: https://crrev.com/5f3868f3ca898ab034543d7d7e219cc3641f14e1 Cr-Commit-Position: refs/heads/master@{#33055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/d8.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 12 months ago (2015-12-28 13:09:25 UTC) #2
Igor Sheludko
lgtm
4 years, 12 months ago (2015-12-28 13:46:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550113002/1
4 years, 12 months ago (2015-12-29 09:32:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-29 09:57:09 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 09:58:14 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f3868f3ca898ab034543d7d7e219cc3641f14e1
Cr-Commit-Position: refs/heads/master@{#33055}

Powered by Google App Engine
This is Rietveld 408576698