Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1550093002: Partial revert of 'Refactor CompositorWorkerManager' (Closed)

Created:
4 years, 12 months ago by Ian Vollick
Modified:
4 years, 12 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of 'Refactor CompositorWorkerManager' This is a partial revert of: https://codereview.chromium.org/1449953002 Most of that CL is inactive code, but it did change the way the compositor thread was created. Instead of a base::Thread, I'd used a WebThreadImplForWorkerScheduler and this seems to have had some performance impact. While I try to figure out why, this CL should get us back to our prior performance. BUG=565789 Committed: https://crrev.com/12eb990f0528415c6fd33e577e09a80c5a9760b8 Cr-Commit-Position: refs/heads/master@{#367051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ian Vollick
On 2015/12/28 16:34:54, vollick wrote: > mailto:vollick@chromium.org changed reviewers: > + mailto:ikilpatrick@chromium.org, mailto:jam@chromium.org, mailto:kinuko@chromium.org, > ...
4 years, 12 months ago (2015-12-28 16:37:47 UTC) #3
haraken
On 2015/12/28 16:37:47, vollick wrote: > On 2015/12/28 16:34:54, vollick wrote: > > mailto:vollick@chromium.org changed ...
4 years, 12 months ago (2015-12-29 01:28:11 UTC) #4
kinuko
lgtm.
4 years, 12 months ago (2015-12-29 03:32:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550093002/1
4 years, 12 months ago (2015-12-29 03:32:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-29 04:38:21 UTC) #11
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 04:39:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12eb990f0528415c6fd33e577e09a80c5a9760b8
Cr-Commit-Position: refs/heads/master@{#367051}

Powered by Google App Engine
This is Rietveld 408576698