Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550063002: Remove base/basictypes.h. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@int-base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base/basictypes.h. BUG=138542 TBR=mark@chromium.org Committed: https://crrev.com/a97fe0c8f0017c2dc3dad1aeb7607f3499e19f32 Cr-Commit-Position: refs/heads/master@{#366958}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -37 lines) Patch
M base/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 2 comments Download
M base/allocator/allocator.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D base/basictypes.h View 1 chunk +0 lines, -26 lines 0 comments Download
M base/callback_list_unittest.nc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/scoped_ptr_unittest.nc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/policy/tools/generate_policy_source.py View 1 2 4 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1551493002 Patch 1

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550063002/1
4 years, 12 months ago (2015-12-26 21:32:08 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/2557)
4 years, 12 months ago (2015-12-26 21:48:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550063002/20001
4 years, 12 months ago (2015-12-26 22:53:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/153046)
4 years, 12 months ago (2015-12-26 23:02:35 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550063002/40001
4 years, 12 months ago (2015-12-26 23:27:32 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/111375) ios_rel_device_ninja on ...
4 years, 12 months ago (2015-12-26 23:37:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550063002/40001
4 years, 11 months ago (2015-12-27 23:10:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/124079)
4 years, 11 months ago (2015-12-27 23:34:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550063002/40001
4 years, 11 months ago (2015-12-28 00:59:00 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-28 02:55:55 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a97fe0c8f0017c2dc3dad1aeb7607f3499e19f32 Cr-Commit-Position: refs/heads/master@{#366958}
4 years, 11 months ago (2015-12-28 02:56:57 UTC) #21
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-05 20:34:07 UTC) #22
Nico
https://codereview.chromium.org/1550063002/diff/40001/base/allocator/BUILD.gn File base/allocator/BUILD.gn (left): https://codereview.chromium.org/1550063002/diff/40001/base/allocator/BUILD.gn#oldcode129 base/allocator/BUILD.gn:129: "$tcmalloc_dir/src/base/basictypes.h", This referred to third_party/tcmalloc/chromium/src/base/basictypes.h which still exists. I'll ...
3 years, 8 months ago (2017-04-13 15:29:51 UTC) #24
Avi (use Gerrit)
3 years, 8 months ago (2017-04-13 16:18:58 UTC) #25
Message was sent while issue was closed. 
https://codereview.chromium.org/1550063002/diff/40001/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (left):

https://codereview.chromium.org/1550063002/diff/40001/base/allocator/BUILD.gn...
base/allocator/BUILD.gn:129: "$tcmalloc_dir/src/base/basictypes.h",
On 2017/04/13 15:29:51, Nico wrote:
> This referred to third_party/tcmalloc/chromium/src/base/basictypes.h which
still
> exists. I'll add this line back.

Oops. Thank you.

Powered by Google App Engine
This is Rietveld 408576698