Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5203)

Unified Diff: chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc b/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
index adc3c6779fe20928b7a4082e6ea089703165f820..31a8d010d933d9c4a88ae238b1d85972e4ae1269 100644
--- a/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/ui/webui/supervised_user_internals_message_handler.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -34,8 +36,8 @@ base::ListValue* AddSection(base::ListValue* parent_list,
section->SetString("title", title);
// Grab a raw pointer to the result before |Pass()|ing it on.
base::ListValue* result = section_contents.get();
- section->Set("data", section_contents.Pass());
- parent_list->Append(section.Pass());
+ section->Set("data", std::move(section_contents));
+ parent_list->Append(std::move(section));
return result;
}
@@ -47,7 +49,7 @@ void AddSectionEntry(base::ListValue* section_list,
entry->SetString("stat_name", name);
entry->SetBoolean("stat_value", value);
entry->SetBoolean("is_valid", true);
- section_list->Append(entry.Pass());
+ section_list->Append(std::move(entry));
}
// Adds a string entry to a section (created with |AddSection| above).
@@ -58,7 +60,7 @@ void AddSectionEntry(base::ListValue* section_list,
entry->SetString("stat_name", name);
entry->SetString("stat_value", value);
entry->SetBoolean("is_valid", true);
- section_list->Append(entry.Pass());
+ section_list->Append(std::move(entry));
}
std::string FilteringBehaviorToString(
@@ -264,7 +266,7 @@ void SupervisedUserInternalsMessageHandler::SendBasicInfo() {
}
base::DictionaryValue result;
- result.Set("sections", section_list.Pass());
+ result.Set("sections", std::move(section_list));
web_ui()->CallJavascriptFunction(
"chrome.supervised_user_internals.receiveBasicInfo", result);

Powered by Google App Engine
This is Rietveld 408576698