Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8237)

Unified Diff: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/engagement/site_engagement_ui.cc
diff --git a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
index f1c29e8ae983e8b179db73452e1dc8a1ca4839de..76c34549c1916038aaa1b6a60e92b31401bf9a61 100644
--- a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
+++ b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/ui/webui/engagement/site_engagement_ui.h"
+#include <utility>
+
#include "base/macros.h"
#include "chrome/browser/engagement/site_engagement_service.h"
#include "chrome/browser/profiles/profile.h"
@@ -25,7 +27,7 @@ class SiteEngagementUIHandlerImpl : public SiteEngagementUIHandler {
SiteEngagementUIHandlerImpl(
Profile* profile,
mojo::InterfaceRequest<SiteEngagementUIHandler> request)
- : profile_(profile), binding_(this, request.Pass()) {
+ : profile_(profile), binding_(this, std::move(request)) {
DCHECK(profile_);
}
@@ -42,10 +44,10 @@ class SiteEngagementUIHandlerImpl : public SiteEngagementUIHandler {
SiteEngagementInfoPtr origin_info(SiteEngagementInfo::New());
origin_info->origin = mojo::String::From(info.first);
origin_info->score = info.second;
- engagement_info.push_back(origin_info.Pass());
+ engagement_info.push_back(std::move(origin_info));
}
- callback.Run(engagement_info.Pass());
+ callback.Run(std::move(engagement_info));
}
private:
@@ -85,5 +87,5 @@ SiteEngagementUI::~SiteEngagementUI() {}
void SiteEngagementUI::BindUIHandler(
mojo::InterfaceRequest<SiteEngagementUIHandler> request) {
ui_handler_.reset(new SiteEngagementUIHandlerImpl(
- Profile::FromWebUI(web_ui()), request.Pass()));
+ Profile::FromWebUI(web_ui()), std::move(request)));
}
« no previous file with comments | « chrome/browser/ui/webui/copresence_ui_handler.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698