Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index 84408c2d15e674b4d4c43a669ca3760e3a6bc245..d8041d426868cb21f4dca63034f7b44442ad63e2 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -5,9 +5,9 @@
#include "chrome/browser/ui/views/translate/translate_bubble_view.h"
#include <stddef.h>
-
#include <algorithm>
#include <string>
+#include <utility>
#include <vector>
#include "base/i18n/string_compare.h"
@@ -116,11 +116,9 @@ void TranslateBubbleView::ShowBubble(
source_language,
target_language));
scoped_ptr<TranslateBubbleModel> model(
- new TranslateBubbleModelImpl(step, ui_delegate.Pass()));
- TranslateBubbleView* view = new TranslateBubbleView(anchor_view,
- model.Pass(),
- error_type,
- web_contents);
+ new TranslateBubbleModelImpl(step, std::move(ui_delegate)));
+ TranslateBubbleView* view = new TranslateBubbleView(
+ anchor_view, std::move(model), error_type, web_contents);
views::BubbleDelegateView::CreateBubble(view);
view->ShowForReason(reason);
}
@@ -260,7 +258,7 @@ TranslateBubbleView::TranslateBubbleView(
always_translate_checkbox_(NULL),
advanced_cancel_button_(NULL),
advanced_done_button_(NULL),
- model_(model.Pass()),
+ model_(std::move(model)),
error_type_(error_type),
is_in_incognito_window_(
web_contents ? web_contents->GetBrowserContext()->IsOffTheRecord()
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_button.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698