Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 1550053002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
index d2e631ffd025fec3ca18d464bbef39b88ce33b98..df2cf752e2ed4d245e6a47461f026ee8ae6cc129 100644
--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h"
+#include <utility>
+
#include "base/callback_helpers.h"
#include "base/logging.h"
#include "chrome/browser/ui/browser.h"
@@ -61,18 +63,18 @@ void OneClickSigninBubbleView::ShowBubble(
switch (type) {
case BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE:
bubble_view_ = new OneClickSigninBubbleView(
- error_message, base::string16(), delegate.Pass(),
- anchor_view, start_sync, false);
+ error_message, base::string16(), std::move(delegate), anchor_view,
+ start_sync, false);
break;
case BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG:
bubble_view_ = new OneClickSigninBubbleView(
- base::string16(), base::string16(), delegate.Pass(),
- anchor_view, start_sync, true);
+ base::string16(), base::string16(), std::move(delegate), anchor_view,
+ start_sync, true);
break;
case BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_SAML_MODAL_DIALOG:
bubble_view_ = new OneClickSigninBubbleView(
- base::string16(), email, delegate.Pass(),
- anchor_view, start_sync, true);
+ base::string16(), email, std::move(delegate), anchor_view, start_sync,
+ true);
break;
}
@@ -98,7 +100,7 @@ OneClickSigninBubbleView::OneClickSigninBubbleView(
const BrowserWindow::StartSyncCallback& start_sync_callback,
bool is_sync_dialog)
: BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
- delegate_(delegate.Pass()),
+ delegate_(std::move(delegate)),
error_message_(error_message),
email_(email),
start_sync_callback_(start_sync_callback),

Powered by Google App Engine
This is Rietveld 408576698